Fix/nonce-ssg #245
Merged
Fix/nonce-ssg #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Step 1 : add incremental test |
- in SSG mode, modify the 99-cspNonce nitro plugin - in SSR mode, modify the headers for prerendered routes
|
step 2 : modify code blocks |
- revert playground config setup to basis - remove uneccessary tryUseNuxt import in 99-cspNonce
|
step 3 - cleanup, playground reverted |
|
This PR looks good. I will review it tomorrow probably but would also love the feedback from @trijpstra-fourlights :) |
|
Hey @vejja Lets reschedule merging this PR to rc.1 to rc.2 instead. It might be safer to do that and focus on releasing today the version 1 which I have already tested. Dont worry though! Your PR is first to be merged to 1.0.0-rc.2 branch so it wont dissapear :) |
trijpstra-fourlights
approved these changes
Oct 18, 2023
playground/nuxt.config.ts
Outdated
Comment on lines
26
to
27
| } | ||
| }, | ||
| nonce: true |
There was a problem hiding this comment.
nitpick: seems to be a left-over from testing. Either we keep it in and add the relevant CSP settings as well or we remove it from the playground.
There was a problem hiding this comment.
Correct, should be removed
There was a problem hiding this comment.
Awesome guys!
Let's keep it in mind for 1.0.0-rc.2 version.
Thanks for the amazing work! 💚
|
Update. Let's make it ready for the 1.0.0-rc.3. I needed to push a fix to 1.0.0-rc.1 because there was a bug that I didn't catch during testing. It was triggered once released to NPM :( |
Baroshem
approved these changes
Oct 25, 2023
dargmuesli
added a commit
to maevsi/maevsi
that referenced
this pull request
Nov 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [nuxt-security](https://nuxt-security.vercel.app) ([source](https://togithub.com/Baroshem/nuxt-security)) | [`1.0.0-rc.2` -> `1.0.0-rc.3`](https://renovatebot.com/diffs/npm/nuxt-security/1.0.0-rc.2/1.0.0-rc.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Baroshem/nuxt-security (nuxt-security)</summary> ### [`v1.0.0-rc.3`](https://togithub.com/Baroshem/nuxt-security/releases/tag/v1.0.0-rc.3): 1.0.0-rc.3 [Compare Source](https://togithub.com/Baroshem/nuxt-security/compare/42f7399289e8edc50b2c68e1e70b1012ac95d8dd...v1.0.0-rc.3) > 1.0.0-rc.3 is the next release candidate #### 🗞️ Next steps We are planning to release one or two more release candidate versions with bugfixes before a stable 1.0.0 version will be released. #### ✅ Migration Guide This version includes⚠️ breaking changes but don't worry, we have prepared migration guide for you 😉 ##### In the previous version, `nonce` could be either an object with a type `NonceOptions` or `false`. ```ts export type NonceOptions = { enabled: boolean; mode?: 'renew' | 'check'; value?: (() => string); } ``` Now it is only a boolean value: ```ts export default defineNuxtConfig({ security: { nonce: true | false } } ``` This change was necessary to resolve security vulnerability for nonce reported by vejja [Baroshem/nuxt-security#257. Read more about the new usage of nonce in this module https://nuxt-security.vercel.app/documentation/headers/csp#nonce 👉 Changelog [compare changes](https://togithub.com/Baroshem/nuxt-security/compare/v1.0.0-rc.1...v1.0.0-rc.3) #### 🚀 Enhancements - Add `credentialless` value to `Cross-Origin-Embedder-Policy` header - Export configuration type - Improve CSP Compliance - ensure csp plugins are added last - Extend CSP support of SSG mode - use cheerio HTML parser for CSP #### 🩹 Fixes - Basic Auth Configuration for Multiple Paths - Nonce value is injected in all pre-rendered pages if the `nonce` option is set to `true` #### 📖 Documentation - Clarify rateLimiter `interval` property #### 🏡 Chore - Improve TS config ####⚠️ Breaking Changes - CSP Compliance #### ❤️ Contributors - Espen Solli Grande ([@​espensgr](https://togithub.com/espensgr)) - vejja ([@​vejja](https://togithub.com/vejja)) - Tristan ([@​Tristan971](https://togithub.com/Tristan971)) - Jonas Thelemann ([@​dargmuesli](https://togithub.com/dargmuesli)) - nsratha ([@​rathahin](https://togithub.com/rathahin)) #### 🏋️♂️ New Contributors - [@​espensgr](https://togithub.com/espensgr) made their first contribution in [Baroshem/nuxt-security#261 - [@​vejja](https://togithub.com/vejja) made their first contribution in [Baroshem/nuxt-security#245 - [@​rathahin](https://togithub.com/rathahin) made their first contribution in [Baroshem/nuxt-security#267 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/maevsi/maevsi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where an immutable nonce value is injected in all pre-rendered pages if the
nonceoption is set totrueTypes of changes
Description
This PR solves the issue
Checklist: