Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable multi-arch Docker images #7

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Feature: Enable multi-arch Docker images #7

merged 2 commits into from
Mar 12, 2023

Conversation

stumpylog
Copy link
Contributor

Draft until #6 is decided and I can rebase or drop the extra commit.

  • Use docker/metadata-action to handle getting image tags and manage :latest. For a tag x.y.z, this will produce the image tags :x.y.z, :x.y and :x, as well as updating :latest as necessary
    • Also provides standard image labels for free
    • See the output here
  • Use docker/login-action to handle authenticating to Docker Hub.
    • I couldn't fully test that portion, for obvious reason, but it should work identically
  • Uses docker/build-push-action and associated
    • adds support for amd64, arm64 and armv7
    • handles the image tags and labels from the metadata
    • Could support caching if desired
  • Some initial logic that could allow pull requests to build, but not push the image

@BaldissaraMatheus
Copy link
Owner

Thanks for your contribution @stumpylog, #6 is already merged sp you can rebase and set it as ready for review. This PR will also resolve #8

…, arm64 and armv7

Uses docker/metadata-action, docker/build-push-action and docker/login-action
@stumpylog stumpylog marked this pull request as ready for review March 12, 2023 15:22
@stumpylog
Copy link
Contributor Author

Done! Let me know if you've questions, I know it's a pretty large changeset.

@BaldissaraMatheus BaldissaraMatheus merged commit c23d71d into BaldissaraMatheus:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants