Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary environment #69

Closed
orhtej2 opened this issue Feb 3, 2024 · 4 comments
Closed

Allow arbitrary environment #69

orhtej2 opened this issue Feb 3, 2024 · 4 comments
Labels
enhancement New feature or request high priority

Comments

@orhtej2
Copy link

orhtej2 commented Feb 3, 2024

While I understand target audience is supposed to run via Docker there's no technical reason why the directory where data is stored and port the app is listening on are not sourced from process.env.

This would allow bare metal hosting at no cost to app's maintainability.

@BaldissaraMatheus
Copy link
Owner

Yes, you're right. It requires a small change so I'll work on it as soon as possible

@BaldissaraMatheus BaldissaraMatheus mentioned this issue Feb 5, 2024
Merged
@BaldissaraMatheus
Copy link
Owner

Hey @orhtej2, I included this change in #73. Can you confirm if it works for you?

@BaldissaraMatheus
Copy link
Owner

This change was included by #73 so I'll close this issue. If someone thinks it's not working properly or could be improved, feel free to comment here and I'll open the issue again.

@orhtej2
Copy link
Author

orhtej2 commented Feb 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

No branches or pull requests

2 participants