Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hide some unnecessary logs; baguarun no_python option bypass #46

Merged
merged 11 commits into from
Jun 25, 2021
Merged

chore: hide some unnecessary logs; baguarun no_python option bypass #46

merged 11 commits into from
Jun 25, 2021

Conversation

shjwudp
Copy link
Member

@shjwudp shjwudp commented Jun 25, 2021 •
edited
Loading

Major changes:

  1. Hide some unnecessary autotune service logs.
  2. baguarun --no_python bypass

@shjwudp shjwudp marked this pull request as draft June 25, 2021 04:13
@shjwudp shjwudp marked this pull request as ready for review June 25, 2021 06:18
@shjwudp shjwudp requested a review from NOBLES5E June 25, 2021 06:19
NOBLES5E
NOBLES5E reviewed Jun 25, 2021
View reviewed changes
bagua/script/baguarun.py Outdated Show resolved Hide resolved
NOBLES5E
NOBLES5E requested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@NOBLES5E NOBLES5E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

NOBLES5E
NOBLES5E reviewed Jun 25, 2021
View reviewed changes
bagua/service/autotune_service.py Outdated
with self.ask_hyperparameters_mutex:
self.param_group_info = param_group_info
default_hyperparameters = BaguaHyperparameter(
buckets=split_bucket_by_bucket_size(
tensor_list,
self.default_bucket_size,
session["bucket_size"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after the fix, the performance of decentralized is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submit bugfix in separate PR and mark fix: in the title

such commits message will go to release notes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@shjwudp shjwudp requested a review from NOBLES5E June 25, 2021 07:09
@shjwudp shjwudp changed the title chore: set a more reasonable default bucket size; hide some unnecessary logs chore: hide some unnecessary logs; baguarun no_python option bypass Jun 25, 2021
@NOBLES5E NOBLES5E merged commit 58719c7 into BaguaSys:master Jun 25, 2021
@pr-triage pr-triage bot added the PR: merged label Jun 25, 2021
NOBLES5E pushed a commit that referenced this pull request Sep 15, 2021
@liuhatry
feat: use nccl 2.10 avg op for all algorithms using averaging (#46)
a9477d5
NOBLES5E pushed a commit that referenced this pull request Sep 15, 2021
@liuhatry @NOBLES5E
feat: use nccl 2.10 avg op for all algorithms using averaging (#46)
ed77711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NOBLES5E NOBLES5E Awaiting requested review from NOBLES5E NOBLES5E is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shjwudp @NOBLES5E