feat(python): associate PyTorch Process Group with Bagua Process Group using cache #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOBLES5E
reviewed
Nov 29, 2021
bagua/torch_api/communication.py
Outdated
| @@ -49,6 +49,8 @@ | |||
| # Process group count for default naming | |||
| _group_count = 0 | |||
|
|
|||
| # Torch process group to bagua process group | |||
| _torch_to_bagua_pg_map = {} | |||
There was a problem hiding this comment.
What if the process group is destroyed? It seems that they will never be released in current implementation
There was a problem hiding this comment.
TorchProcessGroup destory has not be handle yet, I have no good way deal with it.
I try to patch bagua pg on TorchProcessGroup, but if patch class is NCCLProcessGroup, it not work. because C object (NCCLProcessGroup) not support add attribute. The final plan is as it is now. Any suggestions ?
NOBLES5E
reviewed
Nov 29, 2021
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
NOBLES5E
changed the title
NOBLES5E
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.