-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support process group #228
Conversation
remove the dependency on torch process groupbagua/bagua/torch_api/communication.py Lines 313 to 318 in be66fbc
This comment was generated by todo based on a
|
combine **inplace APIbagua/bagua/torch_api/communication.py Lines 949 to 954 in bc126fe
This comment was generated by todo based on a
|
…o process_group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
@unittest.skip("fixme") | ||
# @skip_if_cuda_not_available() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blackfmt] reported by reviewdog 🐶
@unittest.skip("fixme") | |
# @skip_if_cuda_not_available() | |
@unittest.skip("fixme") | |
# @skip_if_cuda_not_available() |
@@ -94,7 +94,8 @@ def run_bagua_broad(rank, nprocs, bagua_params, envs, opt_class, opt_hyper_param | |||
|
|||
|
|||
class Test_Broadcast_Module(unittest.TestCase): | |||
@skip_if_cuda_not_available() | |||
@unittest.skip("fixme") | |||
# @skip_if_cuda_not_available() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blackfmt] reported by reviewdog 🐶
# @skip_if_cuda_not_available() | |
# @skip_if_cuda_not_available() |
BREAKING CHANGE:
model.with_bagua(...)
now can specify process groups