Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fuse optimizer oom and make it stateless #207

Merged
merged 32 commits into from
Nov 2, 2021
Merged

fix: fuse optimizer oom and make it stateless #207

merged 32 commits into from
Nov 2, 2021

Conversation

wangraying
Copy link
Member

@wangraying wangraying commented Sep 17, 2021

BREAKING CHANGE:

  • contrib: bagua.torch_api.contrib.FusedOptimizer is now removed and replaced by bagua.torch_api.contrib.fuse_optimizer

@wangraying wangraying changed the title fix: fuse optimizer oom and make it stateless [DRFAT] fix: fuse optimizer oom and make it stateless [DRAFT] Sep 17, 2021
@wangraying wangraying requested review from NOBLES5E and removed request for NOBLES5E September 18, 2021 11:27
@wangraying wangraying changed the title fix: fuse optimizer oom and make it stateless [DRAFT] fix: fuse optimizer oom and make it stateless Sep 24, 2021
@todo
Copy link

todo bot commented Nov 1, 2021

async algorithm conflict with fused optimizer, can only support flattened inplace bucket.

# TODO: async algorithm conflict with fused optimizer, can only support flattened inplace bucket.
assert do_flatten, "async does not support `do_flatten=False` at present."
if self.step_id < self.warmup_steps:
return super().tensors_to_buckets(tensors, do_flatten)
all_tensors = []


This comment was generated by todo based on a TODO comment in 2fd9eb2 in #207. cc @BaguaSys.

@todo
Copy link

todo bot commented Nov 1, 2021

qadam optimizer maintain `step_id` in its state

# TODO: qadam optimizer maintain `step_id` in its state
self.step_id = 0
self.warmup_steps = warmup_steps


This comment was generated by todo based on a TODO comment in 2fd9eb2 in #207. cc @BaguaSys.

@BaguaSys BaguaSys deleted a comment from todo bot Nov 1, 2021
@BaguaSys BaguaSys deleted a comment from todo bot Nov 1, 2021
@BaguaSys BaguaSys deleted a comment from todo bot Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants