-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support sync batchnorm #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
tests/contrib/test_sync_bn.py
Outdated
"LOCAL_WORLD_SIZE": str(nprocs), | ||
"MASTER_ADDR": "127.0.0.1", | ||
"MASTER_PORT": str(find_free_port()), | ||
"BAGUA_SERVICE_PORT": str(find_free_port()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated find_free_port
func in another pr. please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangraying Which one to use?
tests/internal/common_utils.py
Outdated
return port | ||
except OSError: | ||
port += 1 | ||
raise IOError("no free ports") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blackfmt] reported by reviewdog 🐶
raise IOError("no free ports") | |
raise IOError("no free ports") |
Not official.