Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make full precision decentralized op stateless #126

Merged
merged 23 commits into from
Jul 21, 2021
Merged

feat: make full precision decentralized op stateless #126

merged 23 commits into from
Jul 21, 2021

Conversation

wangraying
Copy link
Member

@wangraying wangraying commented Jul 15, 2021 •
edited
Loading

BREAKING CHANGE:

BaguaBucket.append_decentralized_synchronous_op now only supports full precision decentralized communication.

@NOBLES5E NOBLES5E self-requested a review July 15, 2021 09:00
NOBLES5E
NOBLES5E reviewed Jul 16, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
@wangraying wangraying requested a review from NOBLES5E July 17, 2021 15:18
NOBLES5E
NOBLES5E requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@NOBLES5E NOBLES5E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments.

avoid changes to bagua/torch_api/distributed.py unless necessary

NOBLES5E
NOBLES5E reviewed Jul 20, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 21, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
@wangraying @github-actions
Apply suggestions from code review
30dcdd3 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
NOBLES5E
NOBLES5E reviewed Jul 21, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
NOBLES5E
NOBLES5E reviewed Jul 21, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
NOBLES5E
NOBLES5E reviewed Jul 21, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jul 21, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
NOBLES5E
NOBLES5E requested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@NOBLES5E NOBLES5E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

github-actions[bot]
github-actions bot reviewed Jul 21, 2021
View reviewed changes
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
wangraying and others added 2 commits July 21, 2021 11:38
@wangraying @github-actions
Apply suggestions from code review
bf7d427 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wangraying
.
1420a46
@wangraying wangraying requested a review from NOBLES5E July 21, 2021 06:10
@NOBLES5E NOBLES5E merged commit 0c978e9 into master Jul 21, 2021
@NOBLES5E NOBLES5E deleted the full_prec_decentralized branch July 21, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@NOBLES5E NOBLES5E Awaiting requested review from NOBLES5E NOBLES5E is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangraying @NOBLES5E