Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add low precision decentralized algorithm #103

Conversation

wangraying
Copy link
Member

No description provided.

@wangraying wangraying changed the title feat: add low precision decentralize feat: add low precision decentralized algorithm Jul 5, 2021
@wangraying wangraying requested a review from NOBLES5E July 5, 2021 09:01
Copy link
Contributor

@NOBLES5E NOBLES5E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, also need tests (use a single node simulation result with torch to check if the distributed implementation is correct)

@NOBLES5E NOBLES5E marked this pull request as draft July 8, 2021 04:06
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
compression: If not ``None``, the tensors will be compressed for communication. Currently "MinMaxUInt8" is
supported.
weight (torch.Tensor): Local model of current worker, required for low precision decentralized operation.
left_peer_weight (torch.Tensor): Model replica of current worker's connected left peer, required for low
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to explain what "model replica" is to make user understand how to use it.

A tensor with the same size as weight?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganshaoduo any suggestions?

Copy link
Contributor

@NOBLES5E NOBLES5E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@NOBLES5E NOBLES5E marked this pull request as draft July 9, 2021 09:08
bagua/torch_api/bucket.py Outdated Show resolved Hide resolved
wangraying and others added 2 commits July 12, 2021 21:27
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wangraying wangraying requested a review from NOBLES5E July 13, 2021 09:32
@wangraying wangraying marked this pull request as ready for review July 13, 2021 09:32
@NOBLES5E NOBLES5E merged commit 8c0b2cf into master Jul 13, 2021
@NOBLES5E NOBLES5E deleted the issue-63-Implement_low_precision_decentralized_algorithm_in_open_source_version branch July 13, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement low precision decentralized algorithm in open source version
2 participants