-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add low precision decentralized algorithm #103
feat: add low precision decentralized algorithm #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments, also need tests (use a single node simulation result with torch to check if the distributed implementation is correct)
…ized_algorithm_in_open_source_version
bagua/torch_api/bucket.py
Outdated
compression: If not ``None``, the tensors will be compressed for communication. Currently "MinMaxUInt8" is | ||
supported. | ||
weight (torch.Tensor): Local model of current worker, required for low precision decentralized operation. | ||
left_peer_weight (torch.Tensor): Model replica of current worker's connected left peer, required for low |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to explain what "model replica" is to make user understand how to use it.
A tensor with the same size as weight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ganshaoduo any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.