Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parameter group logic #77

Closed
todo bot opened this issue Jul 1, 2021 · 5 comments
Closed

remove parameter group logic #77

todo bot opened this issue Jul 1, 2021 · 5 comments

Comments

@todo
Copy link

todo bot commented Jul 1, 2021

] # TODO: remove parameter group logic
)
self._bagua_autotune_client.register_models( # TODO: @shjwudp rename to register tensors
autotune_tensor_list, bagua_tensor_group_info
).json() # TODO: @shjwudp error check

With bagua-core 0.3, we no longer need to flatten all at once. Now we can remove parameter groups.


This issue was generated by todo based on a TODO comment in 96cb6fe when #24 was merged. cc @BaguaSys.
@todo todo bot added the todo 🗒️ label Jul 1, 2021
@close-issue-app
Copy link

This issue is closed because it does not meet our issue template. Please read it.

@todo todo bot reopened this Jul 1, 2021
@close-issue-app
Copy link

This issue is closed because it does not meet our issue template. Please read it.

@todo
Copy link
Author

todo bot commented Jul 1, 2021

This issue has been reopened because the TODO comment still exists in bagua/torch_api/distributed.py, as of 6f62a84.


If this was not intentional, just remove the comment from your code. You can also set the reopenClosed config if you don't want this to happen at all anymore.

@create-issue-branch
Copy link

Branch issue-77-remove_parameter_group_logic created!

@NOBLES5E NOBLES5E reopened this Jul 1, 2021
@shjwudp
Copy link
Member

shjwudp commented Jul 7, 2021

closed by #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants