Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI layout improvements #1089

Merged
merged 2 commits into from Jun 6, 2023
Merged

UI layout improvements #1089

merged 2 commits into from Jun 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2023

No description provided.

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioRZMasson Can you try this out and see if it works for you?

3ds Max/.cr/personal/FavoritesList/List.xml Outdated Show resolved Hide resolved
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@ghost
Copy link
Author

ghost commented May 31, 2023

UI related content should not be placed in shared projects resulting in unviewable on the designer and not conducive to dedicated maintenance, please use user control libraries instead.

There are still some detail flaws, I'm basing these adjustments on source code changes and have not run tests.

Later, if necessary, I may need to re-initiate a revision to improve the details.

@bghgary
Copy link
Contributor

bghgary commented May 31, 2023

Are you saying this PR is not ready to merge? I'm not sure what you mean. :-)

@ghost
Copy link
Author

ghost commented Jun 6, 2023

It can be merged and can be further processed at a later stage.

@bghgary bghgary changed the title Fixed UI. UI layout improvements Jun 6, 2023
@bghgary bghgary merged commit d2469cd into BabylonJS:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants