fixes #19

BITPlan · Mar 14, 2021 · 23985e8 · 23985e8
1 parent 6f33aed
commit 23985e8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/frontend/wikicms.py b/frontend/wikicms.py
@@ -132,9 +132,12 @@ def doFilter(self,html,filterKeys):
                 pass
         # https://stackoverflow.com/questions/5041008/how-to-find-elements-by-class
         if "editsection" in filterKeys:
-            for s in soup.select('span',{"class": "mw-editsection"}):
+            for s in soup.select('span.mw-editsection'):
                 s.extract()
-        return str(soup)   
+        html=str(soup)
+        html=html.replace("<html><body>","")
+        html=html.replace("</body></html>","")
+        return html
 
     def getFrame(self,pageTitle):
         '''

diff --git a/setup.py b/setup.py
@@ -12,7 +12,7 @@
     long_description = open('../../README.md').read()
 
 setup(name='pyWikiCMS',
-      version='0.0.13',
+      version='0.0.14',
       description='python implementation of a Mediawiki based Content Management System',
       long_description=long_description,
       long_description_content_type='text/markdown',

diff --git a/tests/test_frontend.py b/tests/test_frontend.py
@@ -144,6 +144,16 @@ def testIssue15(self):
             print(content)
         self.assertFalse('''<span class="mw-editsection">''' in content)
 
+    def testIssue19(self):
+        '''
+        https://github.com/BITPlan/pyWikiCMS/issues/19
+        editsection filter should keep other span's untouched #19
+        '''
+        unfiltered="""<span class="mw-editsection">editsection</span><span class='image'>image section</span>"""
+        frontend=self.server.enableFrontend('cr')
+        filtered=frontend.doFilter(unfiltered,["editsection"])
+        self.assertEqual("""<span class="image">image section</span>""",filtered)     
+
     def testIssue17(self):
         '''
         https://github.com/BITPlan/pyWikiCMS/issues/17