-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prt recovery Fix #2247
Merged
Merged
Prt recovery Fix #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSAL/IdentityCore
Outdated
@@ -1 +1 @@ | |||
Subproject commit 0dace517c56d5f7a90156369466bebd03a577800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
oldalton
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update submodule with changes to add recovery attempt count to prt object
Add recovery attempt count to prt object to fix the ICM where iOS and macOS users seeing multiple prompts when SIF and MFA , both are enabled , but ESTS skips prt recovery for second request since we set the flag to skip prt recovery if prt recovered in the last 5 minutes.
Fix agreed upon by server and client teams is to allow upto 2 prt recovery calls per 5 minutes so that the prt recovery handles both SIF and MFA and customers wont be promoted quite often.
Fix : we will add a prt recovery attempt count and set the skipPrtRecovery flag only when the prt recovery has been attempted 2 times in last 5 minutes.
Type of change
Risk
Additional information