Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prt recovery Fix #2247

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Prt recovery Fix #2247

merged 9 commits into from
Jul 23, 2024

Conversation

Veena11
Copy link
Contributor

@Veena11 Veena11 commented Jul 11, 2024

Proposed changes

Update submodule with changes to add recovery attempt count to prt object

Add recovery attempt count to prt object to fix the ICM where iOS and macOS users seeing multiple prompts when SIF and MFA , both are enabled , but ESTS skips prt recovery for second request since we set the flag to skip prt recovery if prt recovered in the last 5 minutes.

Fix agreed upon by server and client teams is to allow upto 2 prt recovery calls per 5 minutes so that the prt recovery handles both SIF and MFA and customers wont be promoted quite often.

Fix : we will add a prt recovery attempt count and set the skipPrtRecovery flag only when the prt recovery has been attempted 2 times in last 5 minutes.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@Veena11 Veena11 requested a review from a team as a code owner July 11, 2024 20:41
@@ -1 +1 @@
Subproject commit 0dace517c56d5f7a90156369466bebd03a577800

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

This reverts commit c05dd5d, reversing
changes made to 6b368ee.
@Veena11 Veena11 requested a review from a team as a code owner July 22, 2024 22:23
@Veena11 Veena11 merged commit a79256a into dev Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants