Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/multiple tokens 4 #2159

Merged
merged 43 commits into from
Jun 7, 2024
Merged

Feature/multiple tokens 4 #2159

merged 43 commits into from
Jun 7, 2024

Conversation

borgesmb
Copy link
Contributor

Proposed changes

Implements support for multiple access tokens.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

@borgesmb borgesmb requested a review from a team as a code owner May 10, 2024 14:34
@borgesmb borgesmb mentioned this pull request May 10, 2024
Closed
9 tasks
@borgesmb
- Tody up
95b8695
@borgesmb
Merge branch 'dev' into feature/multiple-tokens-4
64aa076 
# Conflicts:
#	MSAL/src/native_auth/controllers/credentials/MSALNativeAuthCredentialsController.swift
#	MSAL/src/native_auth/public/MSALNativeAuthUserAccountResult+Internal.swift
#	MSAL/test/unit/native_auth/controllers/MSALNativeAuthCredentialsControllerTests.swift
@nilo-ms nilo-ms added the native-auth Code related to native authentication label May 15, 2024
@borgesmb
- Removed extension file
9b1be52 
- Moved code to user account result (internal) class
- Added unit tests
@nilo-ms
Copy link
Contributor

nilo-ms commented May 30, 2024

@borgesmb can you please update the CHANGELOG.md file?

borgesmb
borgesmb commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@borgesmb borgesmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

borgesmb
borgesmb commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@borgesmb borgesmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

borgesmb
borgesmb commented May 31, 2024
View reviewed changes
Copy link
Contributor Author

@borgesmb borgesmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@nilo-ms
Update Changelog file
cf2f195 
Rewrite createRetrieveAccessTokenError function, we always try to parse correlation id or message
remove swiftlint warnings
@nilo-ms
Add back 1.3.3 changelog because remove by mistake
6f1a1f4
azure-pipelines[bot]
azure-pipelines bot reviewed Jun 7, 2024
View reviewed changes
MSAL/MSAL.xcodeproj/project.pbxproj
@@ -253,7 +253,6 @@
287F650C2982F4AD00ED90BD /* MSALNativeAuthResponseSerializer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 287F650B2982F4AD00ED90BD /* MSALNativeAuthResponseSerializer.swift */; };
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@nilo-ms nilo-ms merged commit 4ce9fbe into dev Jun 7, 2024
6 checks passed
antonioalwan added a commit that referenced this pull request Jun 18, 2024
@antonioalwan
Merge branch 'dev' into antonioalwan/11_add_error_definitions_migrate
18bba48 
* dev:
  share ownership of CHANGELOG file (#2194)
  Add platform sequence param. (#2192)
  Submodule update (#2189)
  Feature/multiple tokens 4 (#2159)
  Bypassing redirect URI validation for nil URI if developers set bypassRedirectUriValidation property (#2175)
  Update submodule
  Update submodule
  Add new error code when SSO ext config doesn't contain valid Error Handling config

# Conflicts:
#	MSAL/IdentityCore
#	MSAL/src/MSALErrorConverter.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyO SammyO SammyO left review comments

@azure-pipelines Azure Pipelines azure-pipelines left review comments

@nilo-ms nilo-ms nilo-ms approved these changes

@diegojerezba diegojerezba diegojerezba approved these changes

@spetrescu84 spetrescu84 spetrescu84 approved these changes

@dualtagh dualtagh Awaiting requested review from dualtagh

@hieunguyenmsft hieunguyenmsft Awaiting requested review from hieunguyenmsft hieunguyenmsft is a code owner automatically assigned from AzureAD/appleidentityteam

@fidelianawar fidelianawar Awaiting requested review from fidelianawar fidelianawar is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
native-auth Code related to native authentication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borgesmb @nilo-ms @SammyO @diegojerezba @spetrescu84