Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So support ssh-cert flow through broker (Update submodule only) #2134

Merged
merged 5 commits into from
May 2, 2024

Conversation

kaisong1990
Copy link
Contributor

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@kaisong1990 kaisong1990 requested a review from a team as a code owner April 12, 2024 16:41
@@ -1 +1 @@
Subproject commit ab5051f880196698db65ecfbf5803f8fd2b075e1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@kaisong1990 kaisong1990 merged commit 01928d5 into dev May 2, 2024
6 checks passed
@kaisong1990 kaisong1990 deleted the kasong/2644473-ssh-cert branch May 2, 2024 22:46
antonioalwan added a commit that referenced this pull request May 9, 2024
* dev:
  Update automation.yml for Azure Pipelines
  Update automation.yml for Azure Pipelines
  Update automation.yml for Azure Pipelines
  ID Token should be updated when Access Token is refreshed/acquired silently (#2141)
  So support ssh-cert flow through broker (Update submodule only) (#2134)

# Conflicts:
#	MSAL/IdentityCore
antrix1989 added a commit that referenced this pull request May 17, 2024
* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Delete spm-framework.yml

* Update from dev

* remove test

* Reintroduce Minimum OS Version Requirements to Readme

Reintroducing minimum version indicators that were [mistakenly?] removed in #2080

* So support ssh-cert flow through broker (Update submodule only) (#2134)

* cc update

* Update submodule

* Update submodule

* ID Token should be updated when Access Token is refreshed/acquired silently (#2141)

* Changed refresh token to update account and tokens on UserAccountResult

* Unit tests

* Swiftlint

* Updated code comment

* PR Comments

* Update automation.yml for Azure Pipelines

* Update automation.yml for Azure Pipelines

* Update automation.yml for Azure Pipelines

* This PR removes the ADAL keyvault and client secret (#2150)

* Update submodule

* Update yml file

* Revert conf file from testings

* Update msal submodule (#2160)

* Update core.

* Bump version.

* modified:   CHANGELOG.md

* modified:   IdentityCore

---------

Co-authored-by: Ameya Patil <ameyapat@buffalo.edu>
Co-authored-by: Ameya <>
Co-authored-by: Antonio Alwan <antonioalwan@microsoft.com>
Co-authored-by: Hieu Nguyen <hiengu@microsoft.com>
Co-authored-by: Ameya Patil <amepatil@microsoft.com>
Co-authored-by: Hieu Nguyen <65981263+hieunguyenmsft@users.noreply.github.com>
Co-authored-by: Brian Melton-Grace <iambmelton@gmail.com>
Co-authored-by: Kai <kaisong1990@gmail.com>
Co-authored-by: Silviu Petrescu <111577419+spetrescu84@users.noreply.github.com>
Co-authored-by: Swasti Gupta <swastinitb@gmail.com>
antrix1989 added a commit that referenced this pull request May 21, 2024
* Update core.

* Bump version.

* modified:   CHANGELOG.md

* modified:   IdentityCore

* Merge release 1.3.3 to main (#2165)

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Update msal-release-ado-trigger.yml for Azure Pipelines

* Delete spm-framework.yml

* Update from dev

* remove test

* Reintroduce Minimum OS Version Requirements to Readme

Reintroducing minimum version indicators that were [mistakenly?] removed in #2080

* So support ssh-cert flow through broker (Update submodule only) (#2134)

* cc update

* Update submodule

* Update submodule

* ID Token should be updated when Access Token is refreshed/acquired silently (#2141)

* Changed refresh token to update account and tokens on UserAccountResult

* Unit tests

* Swiftlint

* Updated code comment

* PR Comments

* Update automation.yml for Azure Pipelines

* Update automation.yml for Azure Pipelines

* Update automation.yml for Azure Pipelines

* This PR removes the ADAL keyvault and client secret (#2150)

* Update submodule

* Update yml file

* Revert conf file from testings

* Update msal submodule (#2160)

* Update core.

* Bump version.

* modified:   CHANGELOG.md

* modified:   IdentityCore

---------

Co-authored-by: Ameya Patil <ameyapat@buffalo.edu>
Co-authored-by: Ameya <>
Co-authored-by: Antonio Alwan <antonioalwan@microsoft.com>
Co-authored-by: Hieu Nguyen <hiengu@microsoft.com>
Co-authored-by: Ameya Patil <amepatil@microsoft.com>
Co-authored-by: Hieu Nguyen <65981263+hieunguyenmsft@users.noreply.github.com>
Co-authored-by: Brian Melton-Grace <iambmelton@gmail.com>
Co-authored-by: Kai <kaisong1990@gmail.com>
Co-authored-by: Silviu Petrescu <111577419+spetrescu84@users.noreply.github.com>
Co-authored-by: Swasti Gupta <swastinitb@gmail.com>

* modified:   MSAL/IdentityCore

* Updating MSAL framework checksum & url for 1.3.3 [skip ci]

---------

Co-authored-by: Ameya Patil <ameyapat@buffalo.edu>
Co-authored-by: Antonio Alwan <antonioalwan@microsoft.com>
Co-authored-by: Hieu Nguyen <hiengu@microsoft.com>
Co-authored-by: Ameya Patil <amepatil@microsoft.com>
Co-authored-by: Hieu Nguyen <65981263+hieunguyenmsft@users.noreply.github.com>
Co-authored-by: Brian Melton-Grace <iambmelton@gmail.com>
Co-authored-by: Kai <kaisong1990@gmail.com>
Co-authored-by: Silviu Petrescu <111577419+spetrescu84@users.noreply.github.com>
Co-authored-by: Swasti Gupta <swastinitb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants