Multi-tenant PkeyAuth support #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncoolmax
reviewed
Feb 7, 2022
| @@ -57,6 +57,8 @@ | |||
| #define TEST_EMBEDDED_WEBVIEW_MSAL 0 | |||
| #define TEST_EMBEDDED_WEBVIEW_CUSTOM 1 | |||
|
|
|||
| static NSString *const kDeviceIdClaimsValue = @"{\"access_token\":{\"deviceid\":{\"essential\":true}}}"; | |||
There was a problem hiding this comment.
Just curious, in our code base, we have static variable names in the form of s_***, k*** as well as underscore-concatenated capitals, do we have any preference or guidance? :)
There was a problem hiding this comment.
I don't :) But good callout to have an agreement.
jasoncoolmax
approved these changes
Feb 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allows handling PkeyAuth challenges for multiple tenant registrations. Note that MSAL version bump to 1.2 is a requirement to get tenantId from ESTS.
Main changes are in common core - mainly test app updates in MSAL repository allowing manual testing of this feature.
Type of change
Risk
Additional information