Managed Identity - Added file-based detection for Azure Arc #7225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
bgavrilMS,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
|
@trwalke - pls review this. |
bgavrilMS
reviewed
Aug 6, 2024
bgavrilMS
reviewed
Aug 6, 2024
bgavrilMS
reviewed
Aug 6, 2024
| // get the expected Windows or Linux file path of the himds executable | ||
| const fileDetectionPath: string = | ||
| AZURE_ARC_FILE_DETECTION[process.platform as keyof FilePathMap]; | ||
| try { |
There was a problem hiding this comment.
add logging statements for these logic branches
There was a problem hiding this comment.
The logging for this logic exists already on line 142
bgavrilMS
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Azure Arc Managed Identity's "IDENTITY_ENDPOINT" and "IMDS_ENDPOINT" environment variables are undefined, the Managed Identity can still be determined to be an instance of Azure Arc if it has a "himds" executable in the specified path for Windows or Linux.
Manual tests were successful on both Windows and Linux.