Use high precision TS for NAA message time (#7243)

- Use high precision TS for NAA message time to avoid clock skew.
AzureAD · Aug 12, 2024 · 022805b · 022805b
1 parent 630605c
commit 022805b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/change/@azure-msal-browser-bfa268cd-3e3a-441a-a0e7-9d27f1ac6cc8.json b/change/@azure-msal-browser-bfa268cd-3e3a-441a-a0e7-9d27f1ac6cc8.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Use high precision TS for NAA message time #7243",
+  "packageName": "@azure/msal-browser",
+  "email": "kshabelko@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/lib/msal-browser/src/naa/BridgeProxy.ts b/lib/msal-browser/src/naa/BridgeProxy.ts
@@ -16,6 +16,7 @@ import { IBridgeProxy } from "./IBridgeProxy";
 import { InitContext } from "./InitContext";
 import { TokenRequest } from "./TokenRequest";
 import * as BrowserCrypto from "../crypto/BrowserCrypto";
+import { supportsBrowserPerformanceNow } from "../telemetry/BrowserPerformanceClient";
 
 declare global {
     interface Window {
@@ -81,7 +82,9 @@ export class BridgeProxy implements IBridgeProxy {
                         messageType: "NestedAppAuthRequest",
                         method: "GetInitContext",
                         requestId: BrowserCrypto.createNewGuid(),
-                        sendTime: Date.now(),
+                        sendTime: supportsBrowserPerformanceNow()
+                            ? window.performance.now()
+                            : Date.now(),
                     };
                     const request: BridgeRequest = {
                         requestId: message.requestId,
@@ -157,7 +160,9 @@ export class BridgeProxy implements IBridgeProxy {
             messageType: "NestedAppAuthRequest",
             method: method,
             requestId: BrowserCrypto.createNewGuid(),
-            sendTime: Date.now(),
+            sendTime: supportsBrowserPerformanceNow()
+                ? window.performance.now()
+                : Date.now(),
             ...requestParams,
         };
 

diff --git a/lib/msal-browser/src/telemetry/BrowserPerformanceClient.ts b/lib/msal-browser/src/telemetry/BrowserPerformanceClient.ts
@@ -42,7 +42,7 @@ function getPerfMeasurementModule() {
 /**
  * Returns boolean, indicating whether browser supports window.performance.now() function.
  */
-function supportsBrowserPerformanceNow(): boolean {
+export function supportsBrowserPerformanceNow(): boolean {
     return (
         typeof window !== "undefined" &&
         typeof window.performance !== "undefined" &&