Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused or unnecessary dependencies #283

Merged
merged 12 commits into from
Nov 8, 2023

Conversation

peterbom
Copy link
Contributor

@peterbom peterbom commented Nov 1, 2023

The first part of #286.

Removes most of the dependencies identified by depcheck as being unused.

The depcheck tool also identified some missing dependencies, including tslint. Tslint is now deprecated in favour of eslint, so this also converts the project to eslint. No linting is done as part of any build scripts or pipelines, but there is now an npm script to run it manually. I'll create a separate issue to enable automated linting.

The utils dependency was there to support the 'promisification' of node's fs library. This is now unnecessary thanks to the inbuilt fs/promises library.

This also removes some redundant processing from the webpack configuration.

@Tatsinnit
Copy link
Member

💡 This looks great to me, I can surely take a look bit more, but just for idea sake, shall we merge this after tcpDump work - and cut a separate release branch and then merge this.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊🙏 Looks good, thank you! worth test which we all can chip in, fyi @hsubramanianaks for viz

@Tatsinnit Tatsinnit merged commit 04641f5 into Azure:main Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants