Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plan block #209

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Add support for plan block #209

merged 2 commits into from
Nov 29, 2022

Conversation

lonegunmanb
Copy link
Member

Describe your changes

This pull request is based on #180 since we've changed the master branch a lot.

Thanks @hightoxicity for original pr.

Issue number

#180

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests November 28, 2022 10:20 Inactive
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. 🚢

@hightoxicity
Copy link

Thx to have done this work, I am quite busy and was unable to work on it at the moment, sorry for this.

@lonegunmanb
Copy link
Member Author

@hightoxicity It's us who owe you a big thanks, thanks for using our module and thanks for your contribution to this module. We're working on a project called Azure Verified Module, which would convert the legacy modules into a modern version with CI pipeline to improve the quality. To catch up with the schedule I'd like to clean up all remaining issues and prs for these newly converted modules, so I take further steps based on YOUR work, you should take the credit. Our work will fail 100% for sure without the support from the community, without support from you.

Again, thank you!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants