Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AKS API Server VNet Integration #393

Open
1 task done
zioproto opened this issue Jun 15, 2023 · 5 comments
Open
1 task done

Support for AKS API Server VNet Integration #393

zioproto opened this issue Jun 15, 2023 · 5 comments
Labels
preview feature We won't support preview feature request since the service team could withdraw them any time

Comments

@zioproto
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Description

AKS API Server VNet Integration. The product is still in preview but let's track it in a GitHub issue so we are ready to merge a PR as soon is promoted to GA.

Resources:

Status:

New or Affected Resource(s)/Data Source(s)

azurerm_kubernetes_cluster

Potential Terraform Configuration

variable "vnet_integration_enabled" {
  type        = bool
  default     = false
  description = "(Optional) Should API Server VNet Integration be enabled? For more details please visit Use API Server VNet Integration."
}

resource "azurerm_kubernetes_cluster" "main" {
   [..CUT..]
   vnet_integration_enabled = var.vnet_integration_enabled
   [..CUT..]

}

References

No response

@lonegunmanb lonegunmanb added the preview feature We won't support preview feature request since the service team could withdraw them any time label Aug 10, 2023
anroots pushed a commit to bislydev/terraform-azurerm-aks that referenced this issue Apr 12, 2024
@richshadman
Copy link

richshadman commented Jun 25, 2024

Any chance of this possibly getting this reprioritized and reclassified?

I am trying to create a cluster that is entirely within our private network and would love to make use of this feature. Right now trying to set the subnet results in the following error:
image

I would argue that this is actually a bug in the current version of the module as the module allows setting a subnet here:
(https://github.com/Azure/terraform-azurerm-aks/blob/main/main.tf#L262)
image

I think instead of adding a new variable, it would be better to simply set this to true if the subnet is set.

@lonegunmanb @zioproto would it be possible to reclassify as a bug and make the suggested change?

local environment information:
Terraform v1.8.5
on windows_amd64

  • provider registry.terraform.io/azure/azapi v1.13.1
  • provider registry.terraform.io/hashicorp/azuread v2.52.0
  • provider registry.terraform.io/hashicorp/azurerm v3.109.0
  • provider registry.terraform.io/hashicorp/null v3.2.2
  • provider registry.terraform.io/hashicorp/tls v4.0.5

@ryan-grenz-evelyn
Copy link

@richshadman I am hitting the same problem now, though my problem is because of KMS keyvault network access being set to Private. I'm pretty sure a week or so ago when I last deployed the cluster with the same settings the Azure API didn't enforce the vnet integration requirement, but it certainly does now.

Anyway, I would really like to have this switch available and it looks like the @bislydev commit above would add it?

@zioproto
Copy link
Collaborator Author

@richshadman you are right. I identified a mistake on our side, we merged the var.api_server_subnet_id variable that is actually part of the preview feature API Server VNET Intergration, in PR #381

Please bare with us until the feature is declared as GA. Then me and @lonegunmanb will update this module as soon as possible.

@zekena2
Copy link

zekena2 commented Aug 4, 2024

Any info when will it be GA?

anroots-by added a commit to bislydev/terraform-azurerm-aks that referenced this issue Sep 10, 2024
@ddezoysa
Copy link

ddezoysa commented Oct 1, 2024

@richshadman @lonegunmanb @zioproto When this will be in GA? Please help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview feature We won't support preview feature request since the service team could withdraw them any time
Projects
None yet
Development

No branches or pull requests

6 participants