Skip to content

Commit

Permalink
Remove unused net_profile_docker_bridge_cidr
Browse files Browse the repository at this point in the history
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Related: hashicorp/terraform-provider-azurerm#18119
  • Loading branch information
zioproto committed Mar 24, 2023
1 parent d737226 commit 4f05ce5
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 19 deletions.
5 changes: 2 additions & 3 deletions README.md

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion examples/startup/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ module "aks" {
]
}
net_profile_dns_service_ip = "10.0.0.10"
net_profile_docker_bridge_cidr = "170.10.0.1/16"
net_profile_service_cidr = "10.0.0.0/16"
network_plugin = "azure"
network_policy = "azure"
Expand Down
15 changes: 7 additions & 8 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,13 @@ resource "azurerm_kubernetes_cluster" "main" {
}
}
network_profile {
network_plugin = var.network_plugin
dns_service_ip = var.net_profile_dns_service_ip
docker_bridge_cidr = var.net_profile_docker_bridge_cidr
load_balancer_sku = var.load_balancer_sku
network_policy = var.network_policy
outbound_type = var.net_profile_outbound_type
pod_cidr = var.net_profile_pod_cidr
service_cidr = var.net_profile_service_cidr
network_plugin = var.network_plugin
dns_service_ip = var.net_profile_dns_service_ip
load_balancer_sku = var.load_balancer_sku
network_policy = var.network_policy
outbound_type = var.net_profile_outbound_type
pod_cidr = var.net_profile_pod_cidr
service_cidr = var.net_profile_service_cidr

dynamic "load_balancer_profile" {
for_each = var.load_balancer_profile_enabled && var.load_balancer_sku == "standard" ? ["load_balancer_profile"] : []
Expand Down
6 changes: 0 additions & 6 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -622,12 +622,6 @@ variable "net_profile_dns_service_ip" {
default = null
}

variable "net_profile_docker_bridge_cidr" {
type = string
description = "(Optional) IP address (in CIDR notation) used as the Docker bridge IP address on nodes. Changing this forces a new resource to be created."
default = null
}

variable "net_profile_outbound_type" {
type = string
description = "(Optional) The outbound (egress) routing method which should be used for this Kubernetes Cluster. Possible values are loadBalancer and userDefinedRouting. Defaults to loadBalancer."
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">= 3.40, < 4.0"
version = ">= 3.49, < 4.0"
}
tls = {
source = "hashicorp/tls"
Expand Down

0 comments on commit 4f05ce5

Please sign in to comment.