Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test bulk api for vs tests #692

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Nov 3, 2020

this is to test vs tests for the bulk api implementation. DO NOT merge this pr.

Signed-off-by: Guohan Lu lguohan@gmail.com

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
Copy link
Contributor Author

lguohan commented Nov 4, 2020

@kcudnik, i think the build api for syncd has some issue to pass the vs tests. can someone take a look?

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 4, 2020

We recently talked that there is and issue and we want to disable "-l" flag, so why enable it in this pr ? just to test it ?

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 4, 2020

@dmytroxshevchuk you added bulk api support can you take a look why this is failing ?

@dmytroxshevchuk
Copy link
Contributor

@lguohan @kcudnik I added bulk API in syncd. As for me my mistake was with log level in case when bulk api is not implemented(its cause of much logs from syncd), for now it is fixed in PR #687, thanks for this. Regarding vs tests it was passed in my PR #656, when bulk was implemented in syncd, so its interesting why tests failing now.
I will check why the tests fall.

@lguohan
Copy link
Contributor Author

lguohan commented Nov 5, 2020

i do not know if it makes difference, but sync mode is now enabled by default on swss

@dmytroxshevchuk
Copy link
Contributor

WIP: #694

@kcudnik
Copy link
Collaborator

kcudnik commented Jul 6, 2021

this could be revisited, we already have fallback for bulk api in syncd even if vendors don't support that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants