Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] [Innovium] Add new platforms #8967

Open
wants to merge 3 commits into
base: 202012
Choose a base branch
from

Conversation

Hanly-Cameo
Copy link

@Hanly-Cameo Hanly-Cameo commented Oct 13, 2021

Why I did it

Add Cameo boxes support

How I did it

How to verify it

verify with sonic cli(platform driver)

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2021

This pull request introduces 54 alerts when merging c437761 into 4447426 - view on LGTM.com

new alerts:

  • 40 for Wrong number of arguments in a class instantiation
  • 5 for Module imports itself
  • 5 for 'import *' may pollute namespace
  • 4 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2021

This pull request introduces 54 alerts when merging d796c01 into eca9020 - view on LGTM.com

new alerts:

  • 40 for Wrong number of arguments in a class instantiation
  • 5 for Module imports itself
  • 5 for 'import *' may pollute namespace
  • 4 for Modification of parameter with default

@Komil-yc
Copy link

Komil-yc commented Oct 15, 2021

"40 for Wrong number of arguments in a class instantiation" this should be limitation or bug in LGTM, same alerts present in previous PR#7545

"5 for Module imports itself" and *"5 for 'import ' may pollute namespace" happen on other PR(e.g. #6971 ), they are ignored.

@Komil-yc
Copy link

Komil-yc commented Oct 15, 2021

"4 for Modification of parameter with default"
I think they are misjudgment by LGTM.
The variable "lanes" presents a new list and it's elements are copied from A_lanes.
The following "lanes.append" should not modify the original referenced list.
圖片

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2021

This pull request introduces 54 alerts when merging 05e8e44 into 1c86196 - view on LGTM.com

new alerts:

  • 40 for Wrong number of arguments in a class instantiation
  • 5 for Module imports itself
  • 5 for 'import *' may pollute namespace
  • 4 for Modification of parameter with default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants