[Quanta] Add and update platform and device files #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8A-BWDE-56X Switch Vendor: Quanta Switch SKU: IX7-BWDE-32X CPU: Broadwell-DE with BMC ASIC Vendor: Broadcom Switch ASIC: Trident3, BCM56870 Port Configuration: 32x100G Switch Vendor: Quanta Switch SKU: IX8A-BWDE-56X CPU: Broadwell-DE with BMC ASIC Vendor: Broadcom Switch ASIC: Trident3, BCM56770 Port Configuration: 48x25G + 8x100G
…o sonic-buildimage master branch
|
|
|
This pull request introduces 247 alerts and fixes 3 when merging 882e9c8 into bb03e5b - view on LGTM.com new alerts:
fixed alerts:
|
geans-pin
previously approved these changes
Mar 9, 2021
…d modify related code
|
This pull request introduces 207 alerts and fixes 20 when merging 0149d36 into dbc7a45 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 53 alerts and fixes 60 when merging e5a65f4 into 75c29cb - view on LGTM.com new alerts:
fixed alerts:
|
geans-pin
previously approved these changes
Apr 14, 2021
FuzailBrcm
previously approved these changes
Apr 22, 2021
lguohan
reviewed
Apr 25, 2021
device/quanta/x86_64-quanta_ix7_rglbmc-r0/Quanta-IX7-32X/port_config.ini
Outdated
Show resolved
Hide resolved
|
why are these false alerts? |
roberthong-qct
dismissed stale reviews from FuzailBrcm and geans-pin
via
04323af
|
This pull request introduces 53 alerts and fixes 60 when merging 04323af into 27a635a - view on LGTM.com new alerts:
fixed alerts:
|
|
Hi lguohan,
In our fan.py, it’s __init__(self, index, is_psu_fan=False).
So if it’s not psu fan, the second argument is not necessary.
Even though I modified it as Fan(fan_index, False) in [Quanta] Add and update platform and device files by roberthong-qct · Pull Request #6971 · Azure/sonic-buildimage (github.com)<eaf5db1>, there are still 2 alerts:
These are the results of different implementations of __init__ method of class Fan.
|
|
/Azurepipelines run |
|
Commenter does not have sufficient privileges for PR 6971 in repo Azure/sonic-buildimage |
|
/Azurepipelines run |
|
Commenter does not have sufficient privileges for PR 6971 in repo Azure/sonic-buildimage |
1 similar comment
|
Commenter does not have sufficient privileges for PR 6971 in repo Azure/sonic-buildimage |
|
/Azurepipelines run |
|
Commenter does not have sufficient privileges for PR 6971 in repo Azure/sonic-buildimage |
|
/azpw run |
1 similar comment
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jleveque
approved these changes
Jun 21, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 28, 2021
Add device and platform code for ix7-bwde, ix8a-bwde. Support platform API 2.0 for all quanta platforms except for ix1b Co-authored-by: robert.hong <robert.hong@qct.io>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Add device and platform code for ix7-bwde, ix8a-bwde. Support platform API 2.0 for all quanta platforms except for ix1b Co-authored-by: robert.hong <robert.hong@qct.io>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add device and platform code for ix7-bwde, ix8a-bwde.
Support platform API 2.0 for all quanta platforms except for ix1b
How I did it
Implement code
How to verify it
for all quanta platforms except for ix1b:
sfputil show eeprom
show platform fan
show platform psu
show platform syseeprom
show platform temp
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)