Add platform_asic file to each platform folder in sonic-device-data based package #8542

qiluo-msft · 2021-08-20T09:22:25Z

Why I did it

Add platform_asic file to each platform folder in sonic-device-data package. The file content will be used as the ground truth of mapping from PLATFORM_STRING to switch ASIC family.

One use case of the mapping is to prevent installing a wrong image, which targets for other ASIC platforms. For example, currently we have several ONIE images naming as sonic-*.bin, it's easy to mistakenly install the wrong image. With this mapping built into image, we could fetch the ONIE platform string, and figure out which ASIC it is using, and check we are installing the correct image.

After this PR merged, each platform vendor has to add one mandatory text file device/PLATFORM_VENDOR/PLATFORM_STRING/platform_asic, with the content of the platform's switch ASIC family.

TODO I will update https://github.com/Azure/SONiC/wiki/Porting-Guide after this PR is merged.

You can get a list of the ASIC platforms by ls -b platform | cat. Currently the options are

barefoot
broadcom
cavium
centec
centec-arm64
generic
innovium
marvell
marvell-arm64
marvell-armhf
mellanox
nephos
p4
vs

Also support

broadcom-dnx

How I did it

How to verify it

Test one image on DUT. And check the folders under /usr/share/sonic/device

Which release branch to backport (provide reason below if selected)

lgtm-com · 2021-08-23T08:35:58Z

This pull request introduces 5 alerts and fixes 5 when merging 06ca952ea9f36f9734cb3c4a785de4175b5ceb44 into 26c6e7f - view on LGTM.com

new alerts:

2 for Module imports itself
2 for 'import *' may pollute namespace
1 for Unused import

fixed alerts:

2 for Module imports itself
2 for 'import *' may pollute namespace
1 for Unused import

In reply to: 903559173

lgtm-com · 2021-08-24T11:30:37Z

This pull request introduces 5 alerts and fixes 5 when merging d2d518f1c3f2e75ed3d473e14ffaf9b2a17a2df6 into 5ff87e1 - view on LGTM.com

new alerts:

2 for Module imports itself
2 for 'import *' may pollute namespace
1 for Unused import

fixed alerts:

2 for Module imports itself
2 for 'import *' may pollute namespace
1 for Unused import

In reply to: 904557767

lguohan · 2021-08-24T18:21:36Z

i do not think asic vendor and platform vendor are strict hiercharical,
a platform vendor can provide platform driver for two different asic.

suggest not to introduce such hierachy.

In reply to: 904871309

lguohan · 2021-09-01T02:06:29Z

device/arista/x86_64-arista_7280cr3_32d4/platform_asic

@@ -0,0 +1 @@
+broadcom


broadcom

this is available for sonic-broadcom-dnx.bin not in sonic-broadcom.bin

can you differ? #Resolved

~~Technically they are using the same CONFIGURED_PLATFORM. So I cannot differentiate them by this dimention. We could improve in future.~~

this is a must fix

please sync with judy

I fixed the files under dnx platforms. I decided not reduce package content and keep the build/installation behavior as before.

lguohan · 2021-09-01T02:09:54Z

device/arista/x86_64-arista_7050_qx32/platform_asic

@@ -0,0 +1 @@
+broadcom


all arista devices are only available for sonic-broadcom.swi image, not sonic-broadcom.bin image, can you differentiate that?

They are using the same CONFIGURED_PLATFORM (broadcom). So I cannot differentiate them by this dimention. If we have ground truth about bootloader for each platform, we could improve in future.

this is a must fix

please sync with ying.

device/ingrasys/x86_64-ingrasys_s9280_64x-r0/platform.asic

akokhan · 2021-09-20T12:27:21Z

Could you please describe a use-case or intention behind this? Also, are you planning to update platform porting guide with this info? Thank you in advance.

In reply to: 922882822

qiluo-msft · 2021-09-20T12:36:39Z

Updated PR description.

In reply to: 922888780

akokhan · 2021-09-22T07:45:36Z

@qiluo-msft , to avoid adding platform_asic file into the each and every device folder, can't this information be injected into the final image at build stage? Looks like it's the same as PLATFORM configuration option. Or it's something different?

In reply to: 924671625

qiluo-msft · 2021-09-22T09:10:55Z

Thanks for the feedback!
My understanding is that the content is almost same as PLATFORM. However there is no ground truth of the mapping from ONIE platform to ASIC anywhere. And currently all the platforms are built into the image so nothing is missing.

broadcom-dnx is a special ASIC, and PLATFORM is still broadcom.

In reply to: 924671625

lguohan · 2021-09-28T00:59:19Z

device/arista/x86_64-arista_7800r3_48cqm2_lc/platform_asic

@@ -0,0 +1 @@
+broadcom


should be dnx #Closed

lguohan · 2021-09-28T00:59:26Z

device/arista/x86_64-arista_7280cr3mk_32p4/platform_asic

@@ -0,0 +1 @@
+broadcom


dnx #Closed

lguohan · 2021-09-28T00:59:31Z

device/arista/x86_64-arista_7280cr3mk_32d4/platform_asic

@@ -0,0 +1 @@
+broadcom


dnx #Closed

I fixed all 3. Please check.

package

…ice-data" This reverts commit 101ee10e1f1b0e03bb662c0342b48e2107663f31.

qiluo-msft · 2021-09-28T09:25:03Z

@arunlk-dell Could you help review?

lguohan · 2021-09-28T16:30:59Z

device/arista/x86_64-arista_7800_sup/platform_asic

@@ -0,0 +1 @@
+broadcom


broadcom-dnx

lguohan · 2021-09-28T16:31:34Z

device/arista/x86_64-arista_common/platform_asic

@@ -0,0 +1 @@
+broadcom


i do not know what this is. this is common, it should be included in both broadcom and broadcom-dnx

lguohan · 2021-09-28T16:46:42Z

others lgtm.

qiluo-msft · 2021-09-29T07:15:59Z

I just updated https://github.com/Azure/SONiC/wiki/Porting-Guide

wen587

lgtm

qiluo-msft · 2021-09-30T12:17:00Z

/azp run

azure-pipelines · 2021-09-30T12:17:27Z

Azure Pipelines successfully started running 1 pipeline(s).

lguohan

qiluo-msft changed the title ~~Qiluo/devicefolder~~ Reorganize the folder structure under /device Aug 20, 2021

qiluo-msft force-pushed the qiluo/devicefolder branch from 9ae7ace to 06ca952 Compare August 23, 2021 08:04

sonic-net deleted a comment from lgtm-com bot Aug 23, 2021

qiluo-msft marked this pull request as ready for review August 25, 2021 01:18

qiluo-msft requested a review from lguohan as a code owner August 25, 2021 01:18

qiluo-msft marked this pull request as draft August 30, 2021 10:16

qiluo-msft force-pushed the qiluo/devicefolder branch from 22c5aac to 3c6da4c Compare August 30, 2021 12:52

qiluo-msft marked this pull request as ready for review August 31, 2021 12:10

qiluo-msft changed the title ~~Reorganize the folder structure under /device~~ Stripe the content in the package of sonic-device-data Aug 31, 2021

qiluo-msft changed the title ~~Stripe the content in the package of sonic-device-data~~ Reduce the content in the package of sonic-device-data Sep 1, 2021

lguohan reviewed Sep 1, 2021

View reviewed changes

qiluo-msft changed the title ~~Reduce the content in the package of sonic-device-data~~ Reduce the content in the package of sonic-device-data based on asic Sep 2, 2021

qiluo-msft marked this pull request as draft September 17, 2021 02:51

qiluo-msft force-pushed the qiluo/devicefolder branch 2 times, most recently from 3f29360 to 54d7d12 Compare September 17, 2021 14:28

qiluo-msft changed the title ~~Reduce the content in the package of sonic-device-data based on asic~~ Add platform_asic file to each platform folder in sonic-device-data based package Sep 17, 2021

qiluo-msft marked this pull request as ready for review September 20, 2021 07:20

msosyak reviewed Sep 20, 2021

View reviewed changes

device/ingrasys/x86_64-ingrasys_s9280_64x-r0/platform.asic Outdated Show resolved Hide resolved

qiluo-msft force-pushed the qiluo/devicefolder branch from 81e18ec to af21056 Compare September 22, 2021 06:18

wen587 mentioned this pull request Sep 22, 2021

add onie image install's platform verification #8814

Merged

5 tasks

lguohan reviewed Sep 28, 2021

View reviewed changes

qiluo-msft added 8 commits September 28, 2021 09:15

Add platform_asic file to each platform folder

f6349be

Filter based on platform_asic content when building sonic-device-data

57de76b

package

Update platforms using broadcom-dnx

c82d161

Revert "Filter based on platform_asic content when building sonic-dev…

110471a

…ice-data" This reverts commit 101ee10e1f1b0e03bb662c0342b48e2107663f31.

Add unit test for platform folder, add missing platform_asic files

9852a4a

Remove extra file

33a2cca

Fix asic name for broadcom-dnx platforms

369df29

Add platform_asic files for recent supported platforms

2ccb0e6

qiluo-msft force-pushed the qiluo/devicefolder branch from 705e52a to 2ccb0e6 Compare September 28, 2021 09:23

lguohan reviewed Sep 28, 2021

View reviewed changes

device/arista/x86_64-arista_7800_sup/platform_asic Outdated

@@ -0,0 +1 @@

broadcom

Copy link

Collaborator

lguohan Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broadcom-dnx

lguohan reviewed Sep 28, 2021

View reviewed changes

Resolve review comments

1a4a633

wen587 self-requested a review September 30, 2021 02:22

wen587 approved these changes Sep 30, 2021

View reviewed changes

lguohan approved these changes Oct 8, 2021

View reviewed changes

qiluo-msft merged commit add9b65 into sonic-net:master Oct 9, 2021

qiluo-msft deleted the qiluo/devicefolder branch October 9, 2021 02:27

smaheshm added the Chassis for 202106 Branch label Mar 7, 2022

smaheshm mentioned this pull request Mar 8, 2022

[chassis][drop counters tests] Use NO_DROPS group for DNX platforms sonic-net/sonic-mgmt#5295

Merged

4 tasks

arlakshm removed the Chassis for 202106 Branch label Apr 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add platform_asic file to each platform folder in sonic-device-data based package #8542

Add platform_asic file to each platform folder in sonic-device-data based package #8542

qiluo-msft commented Aug 20, 2021 •

edited

Loading

lgtm-com bot commented Aug 23, 2021 •

edited by qiluo-msft

Loading

lgtm-com bot commented Aug 24, 2021 •

edited by qiluo-msft

Loading

lguohan commented Aug 24, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 1, 2021 •

edited by qiluo-msft

Loading

qiluo-msft Sep 1, 2021 •

edited

Loading

lguohan Sep 2, 2021

lguohan Sep 2, 2021

qiluo-msft Sep 17, 2021

lguohan Sep 1, 2021 •

edited by qiluo-msft

Loading

qiluo-msft Sep 1, 2021

lguohan Sep 2, 2021

lguohan Sep 2, 2021

akokhan commented Sep 20, 2021 •

edited by qiluo-msft

Loading

qiluo-msft commented Sep 20, 2021 •

edited

Loading

akokhan commented Sep 22, 2021 •

edited by qiluo-msft

Loading

qiluo-msft commented Sep 22, 2021

lguohan Sep 28, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 28, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 28, 2021 •

edited by qiluo-msft

Loading

qiluo-msft Sep 28, 2021

qiluo-msft commented Sep 28, 2021

lguohan Sep 28, 2021

lguohan Sep 28, 2021

lguohan commented Sep 28, 2021

qiluo-msft commented Sep 29, 2021

wen587 left a comment

qiluo-msft commented Sep 30, 2021

azure-pipelines bot commented Sep 30, 2021

lguohan left a comment

Add platform_asic file to each platform folder in sonic-device-data based package #8542

Add platform_asic file to each platform folder in sonic-device-data based package #8542

Conversation

qiluo-msft commented Aug 20, 2021 • edited Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

lgtm-com bot commented Aug 23, 2021 • edited by qiluo-msft Loading

lgtm-com bot commented Aug 24, 2021 • edited by qiluo-msft Loading

lguohan commented Aug 24, 2021 • edited by qiluo-msft Loading

lguohan Sep 1, 2021 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

broadcom

qiluo-msft Sep 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Sep 1, 2021 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akokhan commented Sep 20, 2021 • edited by qiluo-msft Loading

qiluo-msft commented Sep 20, 2021 • edited Loading

akokhan commented Sep 22, 2021 • edited by qiluo-msft Loading

qiluo-msft commented Sep 22, 2021

lguohan Sep 28, 2021 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

lguohan Sep 28, 2021 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

lguohan Sep 28, 2021 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiluo-msft commented Sep 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Sep 28, 2021

qiluo-msft commented Sep 29, 2021

wen587 left a comment

Choose a reason for hiding this comment

qiluo-msft commented Sep 30, 2021

azure-pipelines bot commented Sep 30, 2021

lguohan left a comment

Choose a reason for hiding this comment

qiluo-msft commented Aug 20, 2021 •

edited

Loading

lgtm-com bot commented Aug 23, 2021 •

edited by qiluo-msft

Loading

lgtm-com bot commented Aug 24, 2021 •

edited by qiluo-msft

Loading

lguohan commented Aug 24, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 1, 2021 •

edited by qiluo-msft

Loading

qiluo-msft Sep 1, 2021 •

edited

Loading

lguohan Sep 1, 2021 •

edited by qiluo-msft

Loading

akokhan commented Sep 20, 2021 •

edited by qiluo-msft

Loading

qiluo-msft commented Sep 20, 2021 •

edited

Loading

akokhan commented Sep 22, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 28, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 28, 2021 •

edited by qiluo-msft

Loading

lguohan Sep 28, 2021 •

edited by qiluo-msft

Loading