[workers] Deprecate "jenkins-kvm-workers" and "jenkins-workers" tags #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
reviewed
Jun 20, 2020
| @@ -1,5 +1,5 @@ | |||
| pipeline { | |||
| agent { node { label 'jenkins-kvm-workers' } } | |||
| agent { node { label 'jenkins-build-workers' } } | |||
There was a problem hiding this comment.
we need to separate this job like what we did for builimage-vs-image before we change the tag.
There was a problem hiding this comment.
Where are we separating the job? There's no "Test" stage for any of these three jobs, so I'm not sure where the split should be,
lguohan
reviewed
Jun 20, 2020
| @@ -1,5 +1,5 @@ | |||
| pipeline { | |||
| agent { node { label 'jenkins-kvm-workers' } } | |||
| agent { node { label 'jenkins-build-workers' } } | |||
There was a problem hiding this comment.
we need to separate this job like what we did for builimage-vs-image before we change the tag.
lguohan
reviewed
Jun 20, 2020
| @@ -1,5 +1,5 @@ | |||
| pipeline { | |||
| agent { node { label 'jenkins-kvm-workers' } } | |||
| agent { node { label 'jenkins-build-workers' } } | |||
There was a problem hiding this comment.
we need to separate this job like what we did for builimage-vs-image before we change the tag.
lguohan
force-pushed
the
master
branch
4 times, most recently
from
0a16fa4
to
f190a18
Compare
lguohan
force-pushed
the
master
branch
2 times, most recently
from
3c082c3
to
76b62b0
Compare
lguohan
force-pushed
the
master
branch
2 times, most recently
from
e187ae2
to
7f37a26
Compare
lguohan
force-pushed
the
master
branch
3 times, most recently
from
bde8e6c
to
2295d0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating all of these build jobs to use the "jenkins-build-workers" tag so that we can have one unified pool of workers for all of our build jobs.
Signed-off-by: Danny Allen daall@microsoft.com