[BUG] Audio Issues when Rotating Device #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes speaker->bluetooth jumping on rotating
ShaunaSong
previously approved these changes
Mar 28, 2022
jamchengms
reviewed
Mar 28, 2022
There was a problem hiding this comment.
one minor thing i noticed in code
val audioManager = context.getSystemService(Context.AUDIO_SERVICE) as AudioManager
audioManager is initialized in isHeadsetActive() instead of start
does it make sense we only set the audioManager once in the start() instead?
Deleted, it comes from constructor, didn't need it there. |
jamchengms
previously approved these changes
Mar 28, 2022
lpeixin
previously approved these changes
Mar 28, 2022
phileo99
reviewed
Mar 28, 2022
...src/main/java/com/azure/android/communication/ui/presentation/manager/AudioSessionManager.kt
Outdated
Show resolved
Hide resolved
…nication-ui-library-android into bug/audio_cutout_on_rotating
iaulakh
approved these changes
Mar 29, 2022
|
tested |
jamchengms
approved these changes
Mar 29, 2022
phileo99
approved these changes
Mar 29, 2022
phileo99
pushed a commit
that referenced
this pull request
Apr 6, 2022
* develop/beta: [Bug] fix test syntax (#177) [Bug] Fix feature flags crash when application context is not Initialized (#175) [Documentation] readme update (#155) [Documentation] Update changelog for beta 2 release (#165) [Refactor] Address Azure review feedback (#164) [Feature] Suggest to update App if new version is available (#169) [Bug] Update String Translation (#162) [Refactor] Remove generics from error handling public API and rename ErroEvent to CommunicationUIErrorEvent [Bug] empty banner view is displayed for stopped transcription and audio recording on screen rotate (#158) [Refactor] Refactoring and code clean up of supported language related files (#149) [Bug] Fixed banner text formatting (#153) [Refactor] update version (#151) [Refactor] Rename method (#147) [Bug] Address UI Test Failures (#138) (#148) [BUG] Audio Issues when Rotating Device (#145) [Bug] Update translation string (#144) [Config] Update code owners (#23) # Conflicts: # azure-communication-ui/azure-communication-ui/src/main/java/com/azure/android/communication/ui/presentation/fragment/setup/components/ErrorInfoView.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?