-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter computes based on computes allow list #2397
Merged
jpmann
merged 12 commits into
main
from
pmanoj/update_notebooks_with_computes_allow_list
Jun 26, 2023
Merged
Filter computes based on computes allow list #2397
jpmann
merged 12 commits into
main
from
pmanoj/update_notebooks_with_computes_allow_list
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aggarwal-k
approved these changes
Jun 23, 2023
amangupta26
approved these changes
Jun 26, 2023
aggarwal-k
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The major reason for failures for the finetune jobs is the user not selecting the right compute. To overcome this issue, we are adding a cell in the notebook to guide the user to select the right compute. Additionally, we are enabling all the optimizations by default. This also helps in reducing the job failures.
Checklist