[Tracing] Add error.type attribute to spans #34619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
pvaneck
force-pushed
the
tracing-retry
branch
3 times, most recently
from
863c4e7
to
d3ecb51
Compare
pvaneck
requested review from
lmazuel,
annatisch,
johanste,
xiangyan99,
tjprescott,
iscai-msft and
kashifkhan
as code owners
lmolkova
reviewed
Mar 28, 2024
sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Mar 28, 2024
johanste
reviewed
Mar 28, 2024
sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry defines an
error.typeattribute, and the guidance is to set it to the string http status code if a non-success status code is returned or just the name of the exception that was raised.Closes: #32804
Part-of: #32803