Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0b11 Hotfix. Reverting [#27913]. Pinning to < Otel 1.15 instead #27958

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

jeremydvoss
Copy link
Member

@jeremydvoss jeremydvoss commented Dec 15, 2022

Description

OTel 1.15 has a memory allocation issue related to Werkzeug. Until that is fixed, we should not update to 1.15. Instead, pinning the exporter to <1.15 in the meantime. Fixes #27900.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jeremydvoss jeremydvoss changed the title Reverting [#27900]. Pinning to < Otel 1.15 instead Release 1.0.0b11 Hotfix. Reverting [#27900]. Pinning to < Otel 1.15 instead Dec 15, 2022
@jeremydvoss jeremydvoss marked this pull request as ready for review December 15, 2022 18:26
@jeremydvoss jeremydvoss changed the title Release 1.0.0b11 Hotfix. Reverting [#27900]. Pinning to < Otel 1.15 instead Release 1.0.0b11 Hotfix. Reverting [#27913]. Pinning to < Otel 1.15 instead Dec 15, 2022
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI dependency check, I believe you just need to update the shared_requirements.txt overrides to match what you have in setup.py

https://github.com/Azure/azure-sdk-for-python/blob/main/shared_requirements.txt#L312-L314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-monitor-opentelemetry-exporter not compatible with latest opentelemetry-[api/sdk] 1.15.0
2 participants