Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6 deprecated #25768

Merged
2 commits merged into from
Aug 22, 2022
Merged

Python 3.6 deprecated #25768

2 commits merged into from
Aug 22, 2022

Conversation

JJHWAN
Copy link
Contributor

@JJHWAN JJHWAN commented Aug 18, 2022

Description

fixed #25148

Updating service bus python requirement from 3.6 to 3.7

@ghost ghost added Service Bus customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Thank you for your contribution JJHWAN! We will review the pull request and get back to you soon.

@SHSongs
Copy link

SHSongs commented Aug 19, 2022

I also checked, it seems to have deleted everything written in version 3.6 or lower in service bus. 👍

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JJHWAN - Thanks for opening a PR! I left a few comments. Once you address them, I can take another look. 🙂

sdk/servicebus/azure-mgmt-servicebus/README.md Outdated Show resolved Hide resolved
sdk/servicebus/azure-mgmt-servicebus/README.md Outdated Show resolved Hide resolved
sdk/servicebus/azure-mgmt-servicebus/setup.py Outdated Show resolved Hide resolved
sdk/servicebus/azure-servicebus/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/servicebus/azure-servicebus/README.md Outdated Show resolved Hide resolved
@JJHWAN
Copy link
Contributor Author

JJHWAN commented Aug 20, 2022

Hi @JJHWAN - Thanks for opening a PR! I left a few comments. Once you address them, I can take another look. 🙂

Thanks for the review I will make changes as you replied :)

Changes with the Review was applied
@JJHWAN
Copy link
Contributor Author

JJHWAN commented Aug 22, 2022

@swathipil I made changes as you said, Can you review it again?

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @JJHWAN!

@swathipil
Copy link
Member

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Aug 22, 2022

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 22, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 4d1b261 into Azure:main Aug 22, 2022
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
# Description

fixed Azure#25148

Updating service bus python requirement from 3.6 to 3.7
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 19, 2023
AKS Fleet 2023 10 15 (Azure#25768)

* rebase

* rebase

* rebase

* rebase

* rebase

* rebase

* rebase

* [Fleet] Fix readme.md for 0815 (Azure#25822)

* fix readme

* format

* remove hub profile

* examples

* fixed example

* fix example

* fix readme

* rebase

* suppress versioning error

* compile
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ServiceBus] Drop support for Python 3.6
3 participants