Use global prettier config/ignore for all check and check-format scripts #17820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-container-registery package.json
…corder-new/rollup.base.config.js
humphd
requested review from
deyaaeldeen,
HarshaNalluru,
jeremymeng,
mikeharder,
praveenkuttappan,
sadasant,
schaabs and
witemple-msft
as code owners
ghost
added
Azure.Identity
customer-reported
|
Thank you for your contribution humphd! We will review the pull request and get back to you soon. |
|
|
deyaaeldeen
approved these changes
Sep 23, 2021
|
This is great! Thank you @humphd! |
|
Thanks for the quick reviews and merging so quickly. I used this PR to make a walk-through video for my open source students, who are getting ready to start doing their first pull requests. This was a great chance for me to show them how I'd approach working in a larger project as a new dev: https://www.youtube.com/watch?v=mNuHA7vH6Wc Your project and code are a great example. Thanks! |
|
Great video @humphd 🤝 |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Feb 16, 2022
Microsoft.App version 2022-01-01-preview (Azure#17820) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Adding new API version 2022-01-01-preview for the new service Microsoft.App (Azure#17135) * Adding swagger and examples * Fix samples * Fix linting errors * fix errors * fix more errors * prettier fixes * Fix the VNET properties * fix the vnet props * Attempt to remove x-ms-identifiers * Add x-ms-identifiers back * Revert "Add x-ms-identifiers back" This reverts commit 44525ab5ace45d9cb1bc85bee2751f015dcaffc6. * Addsourcecontrolapis (Azure#17287) * add sourcecontrol apis * remove space * prettier fix * typo * avocado fix * lint fix * add replicas apis (Azure#17501) * Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (Azure#17479) * Remove dapr components from the ContainerApp object * Fix example * add descriptions * fix * change the auto-rest parameters * Support volume mounts for containerApp (Azure#17530) * add volume mounts * add identifier * refine volume definition * Fix samples (Azure#17534) * Adding managed identity (Azure#17569) * Adding managed identity * prettier fix. * Microsof.app 2022 01 01 preview/add custom domains (Azure#17385) * add support for Custom domains and certificates * add Certificates * Ccertificate as child resource of Managed Env. * Support default custom domain * PUT/DELETE certificate are not long-running * Add Custom Domain Verification Id * domains for all revisions and adding examples * missing examples * one more missing example * Examples+missing paths * Adding missing envelope properties * Addressing PR comments * Removing AKV and Free cert related properties * Prettier and semantic validation fixes * Fixing semantic validations and examples * More fixes * Addressing more PR comments * Updating examples * fixing type * fixing types * Extra properties and responses * misplaced response * whitespace * fix security section * fixing ManageEnvironment securityDefinitions * add 204 delete response * Removing virtual IP and IP Based option * change modelAsString * Addressing ARM PR comments * Removing 404 response from example * renaming custom hostname analysis operation * mark certificate as tracked resource * fix sample * Use Certificate Id instead of Certificate name Co-authored-by: Ruslan Yakushev 🚴 <ruslany@microsoft.com> Co-authored-by: vinisoto <vinisoto@hotmail.com> * Add new properties for ContainerApp (Azure#17483) * add ephemeral storage * add outbound ip * add listsecrets * fix CI * fix example * fix * add identifier * fix * add example * mars as secret * Add storages operation for managedEnvironment (Azure#17545) * add storage * fix * fix typo * Add EasyAuth configuration APIs for ContainerApp (Azure#17492) * Add Easy Auth Config related APIs for ContainerApp * Use common type ProxyResource * Update description * update per validation * typo fix * fix validation error * Update sample and description * Update because ARM prefer string than boolean * Add static web identity provider * Add container probes (Azure#17535) * Add container probes * minor fix * Use execute instead of exec'd, add identifier * remove exec from preview * use integer instead of intorstring * Add `internal` property under VnetConfiguration for internalOnly environments (Azure#17656) * Add internal property under VnetConfiguration for internalOnly environments * Update examples * Add Dapr Components collection APIs (Azure#17552) * Add daprComponents * update readme * Fix linting errors * More lint fixes * prettier fixes * make dapr component a tracked resource * fix the patch * fix lint errors * Revert "fix lint errors" This reverts commit 045f1d94bddf3527eab98b7a376070ab30fdd760. * Revert "fix the patch" This reverts commit 14521103e848e09762185f832c0270c16ed16efd. * Revert "make dapr component a tracked resource" This reverts commit 239268eda070ff37f26e8a772adacdd26bbf0937. * Fix linter issues * fix wrong fix * fix linter * fix the operationids (Azure#17809) * correct resource name (Azure#17846) * Add custom open id providers support (Azure#17855) * Add custom open id providers support * Update description Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Vaclav Turecek <vturecek@microsoft.com> Co-authored-by: Vini Soto <18271663+vinisoto@users.noreply.github.com> Co-authored-by: vinisoto <vinisoto@hotmail.com> Co-authored-by: erich-wang <eriwan@microsoft.com> Co-authored-by: Mike Vu <mdhvu@uwaterloo.ca> Co-authored-by: Sanchit Mehta <sanmeht@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15772. I've added config and ignore flags to all the
formatandcheck-formatscripts that were missing them. I've also fixed a number of related issues that I encountered during the work (i.e., I couldn't getrush check-formatto pass without these). Please let me know if you want any of these removed:tsdoc-metadata.jsonto.prettierignoreso thatrush check-formatcould pass for@azure/core-rest-pipeline. I did this based on the change in Remove and ignore tsdoc-metadata.json #14681.sdk/containerregistry/perf-tests/container-registry/package.jsonsince they were not pointing to the correct prettier config/ignore locationcheck-formattosdk/identity/identity/test/manual/package.jsonin order to match all the otherpackage.jsonfiles and how they use prettier.--checkto--list-differentincommon/tools/eslint-plugin-azure-sdk/package.jsonin order to match how all othercheck-formatscripts work.formaton a few files that were failing, when check with the new config.Let me know if I've missed any other locations. It looks to me like I've got them all, but I'm new to this code.