Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Fix cmdcov issue: remove tested_command.txt reference #455

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Jun 21, 2024

As tested_command.txt could potentially expose secrets, it has been ignored in PR

However, this change has caused the cmdcov tool to throw an exception because it cannot find tested_command.txt. Additionally, we have determined that tested_command.txt does not contribute to test coverage. Therefore, this PR aims to remove the logic that analyzes tested_command.txt and mitigate the exception.

Exception before fixing:
image

Works well after fixing:
image

Copy link

Hi @Pan-Qi,
Please write the description of change into HISTORY.rst.
If you want to release a new azdev version, please update the VERSION in init.py as well.

@Pan-Qi Pan-Qi marked this pull request as draft June 21, 2024 02:43
@Pan-Qi Pan-Qi marked this pull request as ready for review June 21, 2024 03:00
@Pan-Qi Pan-Qi requested a review from wangzelin007 June 21, 2024 03:00
@Pan-Qi Pan-Qi changed the title Fix azdev cmdcov file can not found issue {CI} Fix cmdcov issue: remove tested_command.txt reference Jun 21, 2024
@wangzelin007 wangzelin007 merged commit 8f5eb98 into dev Jun 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants