add testcases #2822
Merged
add testcases #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenxiJiang333
requested review from
iscai-msft,
msyyc and
tadelesh
as code owners
msyyc
reviewed
Sep 11, 2024
| @@ -209,3 +209,76 @@ async def test_nested_proxy_resources_list_by_top_level_tracked_resource(client) | |||
| assert result.name == "nested" | |||
| assert result.type == "Azure.ResourceManager.Models.Resources/topLevelTrackedResources/top/nestedProxyResources" | |||
| assert result.system_data.created_by == "AzureSDK" | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
There was a problem hiding this comment.
@ChenxiJiang333 Please run pnpm change add to add changelog.
iscai-msft
approved these changes
Sep 11, 2024
| ) | ||
|
|
||
|
|
||
| # @pytest.mark.asyncio |
There was a problem hiding this comment.
can we delete these commented out tests?
There was a problem hiding this comment.
It is not bad to keep it. After we fix the codegen, we could open the commented code directly.
|
thank you @ChenxiJiang333 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testcases for several cadl-ranch scenarios