-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for chat messages dataset #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on the re-design. It's great work but let's sync! The big ideas here
- Shift to memoryInterface for anything an operator/pyrit wants to keep track of
- chat_message_normalizer should be the "truth", but we should be able to convert to/from that other formats from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may want us to update the documentation later; not because it's unclear, but because datasets workflows are different from most of pyrit. E.g. we generally don't want folks to store multi-turn conversations using this.
Description
This PR adds:
ChatMessagesDataset
object.pydantic
functions (i.e.,json
,parse_raw
)ChatMessagesDataset
file.ChatMessage
model to support other parameters available in the OpenAI Completions API.Tests
Documentation