Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rot13 #80

Merged
merged 9 commits into from
Mar 4, 2024
Merged

add rot13 #80

merged 9 commits into from
Mar 4, 2024

Conversation

pgrek001
Copy link
Contributor

@pgrek001 pgrek001 commented Mar 1, 2024

Description

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@rdheekonda
Copy link
Contributor

Excellent job @pgrek001 for adding a new converter here!

Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests fail, it's due to my latest change. It won't break anything existing though. If you want to pre-emptively fix, merge main and change the return type to match, but I'm happy to fix it up. Sorry, should have postponed my latest pull until this went in!

@romanlutz
Copy link
Contributor

If the tests fail, it's due to my latest change. It won't break anything existing though. If you want to pre-emptively fix, merge main and change the return type to match, but I'm happy to fix it up. Sorry, should have postponed my latest pull until this went in!

I quickly fixed it (I think)

@pgrek001 pgrek001 merged commit f7f62b7 into Azure:main Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants