Adding Support for 1:N PromptConverters #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
Mar 1, 2024
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
nina-msft
previously requested changes
Mar 1, 2024
romanlutz
approved these changes
Mar 1, 2024
jbolor21
approved these changes
Mar 1, 2024
rdheekonda
reviewed
Mar 1, 2024
rdheekonda
reviewed
Mar 1, 2024
rdheekonda
reviewed
Mar 1, 2024
rlundeen2
dismissed
nina-msft’s stale review
made the change but she's out today :)
rdheekonda
approved these changes
Mar 1, 2024
romanlutz
approved these changes
Mar 1, 2024
jbolor21
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this, converters could only convert a prompt from one thing to another, 1:1.
This PR allows us to convert prompts 1:N. This is needed if we want a single prompt Converter to translate to N different prompt variations.
I also added a
include_originalflag to the orchestrator that allows the converter to keep the original version.Tests
Documentation