Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasets folder to wheel #61

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

romanlutz
Copy link
Contributor

Description

Adding the datasets folder to the wheel because it otherwise causes issues when users don't provide a dataset and use the default (as it's not part of the wheel but expected to be present).

Note that it isn't inside the pyrit package directory, so the installation puts it into a directory at the same level as pyrit like another python package which is not great and could cause confusion and conflicts. We should absolutely address this in a future release, but it'll unblock the next one.

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@jbolor21 jbolor21 self-assigned this Feb 22, 2024
@romanlutz romanlutz merged commit cdae12b into Azure:main Feb 22, 2024
4 checks passed
@romanlutz romanlutz deleted the romanlutz/add_datasets_to_wheel branch February 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants