Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Details to Contributor Guide About Forking/PRs #59

Merged

Conversation

nina-msft
Copy link
Contributor

@nina-msft nina-msft commented Feb 22, 2024

Description

Add info about how to contribute via Git to the Contributor Guide, from creating a fork to adding the remote locally to creating a PR 🤠 ✨

See markdown preview here: https://github.com/nina-msft/PyRIT/blob/users/nina-msft/contributor-guide-additions/doc/contributing.md

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@nina-msft nina-msft marked this pull request as ready for review February 22, 2024 01:36
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very nitpicky comments. This is great, thanks!

doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
doc/contributing.md Outdated Show resolved Hide resolved
@nina-msft nina-msft merged commit 6748b48 into Azure:main Feb 22, 2024
4 checks passed
@nina-msft nina-msft deleted the users/nina-msft/contributor-guide-additions branch February 22, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants