Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HF Azure ML deployment managed compute to allow liveness probe configuration #52

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Update HF Azure ML deployment managed compute to allow liveness probe configuration #52

merged 6 commits into from
Feb 21, 2024

Conversation

rdheekonda
Copy link
Contributor

@rdheekonda rdheekonda commented Feb 21, 2024 •
edited
Loading

Description

  • When deploying larger models on Azure ML managed compute (ex., cognitivecomputations-Wizard-Vicuna-30B-Uncensored), we were encountering ResourceNotReady errors, so we modified the deployment script to enable passing liveness probe configuration settings as an environment variable.
  • Added troubleshooting steps for the ResourceNotReady error in HF Azure ML model deployments.

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

updated Azure ML deployment compute to allow liveness probe configura…
d488433 
…tion details for avoiding resourcenotready issues
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results

114 tests  ±0   114 ✅ ±0   10s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 44e0907. ± Comparison against base commit c67f938.

♻️ This comment has been updated with latest results.

@rdheekonda rdheekonda changed the title Updated Azure ML deployment compute to allow liveness probe configuration Update HF Azure ML deployment managed compute to allow liveness probe configuration Feb 21, 2024
romanlutz
romanlutz approved these changes Feb 21, 2024
View reviewed changes
doc/deployment/Troubleshooting Guide HF AzureML.md Outdated Show resolved Hide resolved
doc/deployment/Troubleshooting Guide HF AzureML.md Outdated Show resolved Hide resolved
@rdheekonda rdheekonda merged commit 4da4c4e into main Feb 21, 2024
7 checks passed
@rdheekonda rdheekonda deleted the users/rdheekonda/fix-aml-deployment-small-issues branch February 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlundeen2 rlundeen2 rlundeen2 approved these changes

@romanlutz romanlutz romanlutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdheekonda @romanlutz @rlundeen2