Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing environment for completions and embeddings #46

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

rlundeen2
Copy link
Contributor

Description

This standardizes how we pass environment variables to embeddings and completions, using the same paradigms that chatcompletions use

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

Copy link

github-actions bot commented Feb 15, 2024

Test Results

105 tests  +10   105 ✅ +10   12s ⏱️ +3s
  1 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit b1d86f4. ± Comparison against base commit 9de40a8.

This pull request removes 3 and adds 13 tests. Note that renamed tests count towards both.
tests.test_common_environment ‑ test_environment_variables_prefers_passed
tests.test_common_environment ‑ test_environment_variables_throws_if_not_set
tests.test_common_environment ‑ test_environment_variables_uses_default
tests.test_azure_completion ‑ test_invalid_deployment_raises
tests.test_azure_completion ‑ test_invalid_endpoint_raises
tests.test_azure_completion ‑ test_invalid_key_raises
tests.test_azure_completion ‑ test_valid_init
tests.test_azure_completion ‑ test_valid_init_env
tests.test_azure_text_embedding ‑ test_invalid_deployment_raises
tests.test_azure_text_embedding ‑ test_invalid_endpoint_raises
tests.test_azure_text_embedding ‑ test_invalid_key_raises
tests.test_azure_text_embedding ‑ test_valid_init
tests.test_azure_text_embedding ‑ test_valid_init_env
…

♻️ This comment has been updated with latest results.

pyrit/embedding/azure_text_embedding.py Outdated Show resolved Hide resolved
pyrit/completion/azure_completions.py Outdated Show resolved Hide resolved
@rlundeen2 rlundeen2 merged commit b4beb27 into main Feb 16, 2024
7 checks passed
@rlundeen2 rlundeen2 deleted the users/rlundeen/2_15_adding_env_completions branch February 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants