Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with RedTeamingBot attack strategy #36

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

rlundeen2
Copy link
Contributor

@rlundeen2 rlundeen2 commented Feb 7, 2024

Description

Previously in RedTeamingBot, attack_strategy was mandatory but documented as okay to be empty. This is problematic because then the is_chat_complete function doesn't always detect the end of a conversation since the token isn't present. A couple of our notebooks were broken because of this. This PR does the following:

  • Sets attack_strategy by default to a valid value
  • In init, check that the complete token is present in the attack_strategy

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

Copy link

github-actions bot commented Feb 7, 2024

Test Results

85 tests  +2   85 ✅ +2   8s ⏱️ +2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit acd591e. ± Comparison against base commit c070249.

♻️ This comment has been updated with latest results.

@rlundeen2 rlundeen2 merged commit bfeaab4 into main Feb 8, 2024
7 checks passed
@rlundeen2 rlundeen2 deleted the users/rlundeen/2_7_ai_redteam_default branch February 8, 2024 21:02
@rlundeen2 rlundeen2 restored the users/rlundeen/2_7_ai_redteam_default branch February 8, 2024 22:23
@romanlutz romanlutz deleted the users/rlundeen/2_7_ai_redteam_default branch February 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants