-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt Normalizer and Refactor #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding environment var for embewdding * adding tests for defaults * fixing issues with test * fixing build issues * removing configuration * build system
* adding environment var for embewdding * adding tests for defaults * fixing issues with test * fixing build issues * removing configuration * build system
* adding environment var for embewdding * adding tests for defaults * fixing issues with test * fixing build issues * removing configuration * build system
Test Results83 tests +11 83 ✅ +11 9s ⏱️ -1s Results for commit 9a46037. ± Comparison against base commit 4aace51. This pull request removes 1 and adds 12 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Can you add a more descriptive PR title? 🙂 |
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
reviewed
Feb 1, 2024
rdheekonda
approved these changes
Feb 2, 2024
cseifert1
reviewed
Feb 2, 2024
gotcha; that clarfies.
________________________________
From: rlundeen2 ***@***.***>
Sent: Friday, February 2, 2024 10:48 AM
To: Azure/PyRIT ***@***.***>
Cc: Christian Seifert (HE| HIM) ***@***.***>; Comment ***@***.***>
Subject: Re: [Azure/PyRIT] Prompt Normalizer and Refactor (PR #32)
@rlundeen2 commented on this pull request.
________________________________
In pyrit/prompt_target/prompt_target.py<#32 (comment)>:
@@ -0,0 +1,25 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT license.
+
+import abc
+from pyrit.memory import MemoryInterface
+
+
+class PromptTarget(abc.ABC):
+ memory: MemoryInterface
+ supported_transformers: list
The idea is there are only some transformers a target supports. AzureOpenAI won't accept a word document, for example, but a onedrive target will accept most everything. This will need to be flushed out as our target and transformer library increases (e.g. we may want categories and things) but to start I thought a list was enough.
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA4GNNN7BNKGD4N2GY55N33YRUYGXAVCNFSM6AAAAABCTZJ3FWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRQGA4DGMZRGQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
romanlutz
reviewed
Feb 3, 2024
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
…hub.com/Azure/PyRIT into users/rlundeen/1_19_prompt_normalizer_1
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
…hub.com/Azure/PyRIT into users/rlundeen/1_19_prompt_normalizer_1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This rearchitects the code to use prompt normalizer, prompt targets, prompt transformers, and orchestrators.
It also has some minor updates with memory, which is used to keep track of conversations in the normalizer.
Tests
Documentation