Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Demo Notebook Prerequisites #30

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Update Demo Notebook Prerequisites #30

merged 4 commits into from
Jan 31, 2024

Conversation

rdheekonda
Copy link
Contributor

@rdheekonda rdheekonda commented Jan 30, 2024 •
edited
Loading

Description

  1. Updated prerequisites documentation for running demo notebooks.
  2. Removed Azure CLI from the wiki prerequisites.
image

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Test Results

72 tests  ±0   72 ✅ ±0   6s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4e50903. ± Comparison against base commit b67f726.

♻️ This comment has been updated with latest results.

nina-msft
nina-msft reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@nina-msft nina-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another approach could be to put all of this information into this setup page: https://github.com/Azure/PyRIT/blob/users/rdheekonda/fix-prerequisites-notebooks-and-wiki/examples/setup/azure_openai_setup.ipynb

There are some notebooks in examples/code that will reference this setup, and it seems like this can be leveraged for all 3 of these notebooks.

@rdheekonda
Copy link
Contributor Author

Another approach could be to put all of this information into this setup page: https://github.com/Azure/PyRIT/blob/users/rdheekonda/fix-prerequisites-notebooks-and-wiki/examples/setup/azure_openai_setup.ipynb

There are some notebooks in examples/code that will reference this setup, and it seems like this can be leveraged for all 3 of these notebooks.

Good suggestion, updated. Thanks

romanlutz
romanlutz approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/code/azure_embeddings_and_completions.ipynb Outdated Show resolved Hide resolved
examples/code/scoring.ipynb Outdated Show resolved Hide resolved
examples/demo/1_gandalf.ipynb Outdated Show resolved Hide resolved
examples/demo/3_gandalf_AML_endpoint_red_team_bot.ipynb Outdated Show resolved Hide resolved
examples/demo/4_gandalf_HuggingFace_red_team_bot.ipynb Outdated Show resolved Hide resolved
examples/setup/azure_openai_setup.ipynb Outdated Show resolved Hide resolved
rdheekonda
rdheekonda commented Jan 31, 2024
View reviewed changes
Copy link
Contributor Author

@rdheekonda rdheekonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated text

@rdheekonda @romanlutz
Apply suggestions from code review
4e50903 
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
@rdheekonda rdheekonda merged commit 4aace51 into main Jan 31, 2024
7 checks passed
@rdheekonda rdheekonda deleted the users/rdheekonda/fix-prerequisites-notebooks-and-wiki branch January 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

@nina-msft nina-msft nina-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdheekonda @romanlutz @nina-msft