Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX ValueError with Azure TTS Target in Single Turn Conversation Using PromptSendingOrchestrator #278

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

nina-msft
Copy link
Contributor

@nina-msft nina-msft commented Jul 11, 2024

Description

Bug fix to address the ValueError with Azure TTS Target in Single Turn Conversations - although this affects any target that enforces single turn conversations (e.g. AzureBlobStorageTarget, AzureOpenAICompletionTarget, etc.).

Fix will add prompt request information to memory after it is sent through to the target (instead of before). In the case of an exception being thrown, both request and exception will be added to memory.

** There is another bug fix within Translation Converter here as well, discovered while running Jupytext. There is no capitalization normalization on the keys of the languages provided in the response, so there was a KeyError when requesting the language if provided in different capitalization.

Tests and Documentation

Two new unit tests to verify that request and response are added to memory as expected.
Documentation updated to use AzureTTSTarget with the PromptSendingOrchestrator, which verifies the end to end scenario of the original bug.

Jupytext ran for the addition to the orchestrator code documentation.

Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on if you agree with my comments. If you punt or want to talk about any let me know!

@nina-msft nina-msft merged commit 98c5c78 into Azure:main Jul 12, 2024
4 checks passed
@nina-msft nina-msft deleted the users/nina-msft/2922-bug-fix branch July 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants