-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX ValueError with Azure TTS Target in Single Turn Conversation Using PromptSendingOrchestrator #278
Merged
nina-msft
merged 10 commits into
Azure:main
from
nina-msft:users/nina-msft/2922-bug-fix
Jul 12, 2024
Merged
FIX ValueError with Azure TTS Target in Single Turn Conversation Using PromptSendingOrchestrator #278
nina-msft
merged 10 commits into
Azure:main
from
nina-msft:users/nina-msft/2922-bug-fix
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
Jul 11, 2024
romanlutz
reviewed
Jul 11, 2024
rlundeen2
reviewed
Jul 12, 2024
rlundeen2
reviewed
Jul 12, 2024
rlundeen2
reviewed
Jul 12, 2024
rlundeen2
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on if you agree with my comments. If you punt or want to talk about any let me know!
romanlutz
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix to address the ValueError with Azure TTS Target in Single Turn Conversations - although this affects any target that enforces single turn conversations (e.g. AzureBlobStorageTarget, AzureOpenAICompletionTarget, etc.).
Fix will add prompt request information to memory after it is sent through to the target (instead of before). In the case of an exception being thrown, both request and exception will be added to memory.
** There is another bug fix within Translation Converter here as well, discovered while running Jupytext. There is no capitalization normalization on the keys of the languages provided in the response, so there was a KeyError when requesting the language if provided in different capitalization.
Tests and Documentation
Two new unit tests to verify that request and response are added to memory as expected.
Documentation updated to use AzureTTSTarget with the PromptSendingOrchestrator, which verifies the end to end scenario of the original bug.
Jupytext ran for the addition to the orchestrator code documentation.