[DRAFT] FEAT Update Data Type Serializer Functionality to Support MultiModal #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlundeen2
reviewed
Jul 16, 2024
| else: | ||
| raise ValueError(f"Data type {data_type} without prompt text not supported") | ||
|
|
||
|
|
||
| class DiskStorageIO(StorageIO): |
There was a problem hiding this comment.
This is good design, great work
rlundeen2
reviewed
Jul 16, 2024
| container_client = self.azure_blob_service_client.get_container_client(container=self.container_name) | ||
| matched_blobs = container_client.list_blobs(name_starts_with=path) | ||
| # TODO: Does this logic really work? | ||
| return len(matched_blobs) > 1 and any(blob.name == str(path) for blob in matched_blobs) |
There was a problem hiding this comment.
Before closing please verify the case where there is just one blob :)
rlundeen2
reviewed
Jul 16, 2024
| self.azure_blob_service_client = azure_blob_service_client | ||
| self.container_name = container_name | ||
|
|
||
| def read(self, path: Path | str) -> bytes: |
There was a problem hiding this comment.
should we make all these methods async? I think it's probably worth it to change to async only
There was a problem hiding this comment.
work with Raja though, I won't block on it. I am okay with sync, just not my pref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance the
data_type_serializerfunctionality to support multimodal capabilities using Azure SQL Database and Azure Storage Account deployed.CC: @rdheekonda @rlundeen2
Tests and Documentation