Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT upgrading AOAI version #264

Merged
merged 1 commit into from
Jun 28, 2024
Merged

MAINT upgrading AOAI version #264

merged 1 commit into from
Jun 28, 2024

Conversation

jbolor21
Copy link
Contributor

Description

Upgrading AOAI version to 2024-02-01

Tests and Documentation

Reran notebooks and unit tests

@jbolor21 jbolor21 marked this pull request as ready for review June 28, 2024 16:56
romanlutz
romanlutz approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Did you try each of them to make sure they work?

@jbolor21 jbolor21 merged commit 00c58fb into Azure:main Jun 28, 2024
2 of 3 checks passed
@jbolor21 jbolor21 deleted the users/bjagdagdorj/azure_upgrade branch June 28, 2024 18:39
@kzhen12
Copy link

kzhen12 commented Jul 24, 2024

I think you guys broke something, new pyrit update isn't working.
line 20
await target_llm.send_prompt_async(prompt_request=request) # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: 'await' outside function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbolor21 @kzhen12 @romanlutz