Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Error Handling for Scorers #256

Merged
merged 2 commits into from
Jun 27, 2024
Merged

MAINT Error Handling for Scorers #256

merged 2 commits into from
Jun 27, 2024

Conversation

jbolor21
Copy link
Contributor

Description

Adding exception handling for malformed jsons in scorers

Tests and Documentation

Added new unit tests

romanlutz
romanlutz reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is going to super valuable.

pyrit/score/self_ask_category_scorer.py Outdated Show resolved Hide resolved
tests/score/test_self_ask_meta_scorer.py Show resolved Hide resolved
@jbolor21 jbolor21 marked this pull request as ready for review June 25, 2024 21:26
rlundeen2
rlundeen2 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Can you make sure the scorer jupyter notebooks all run before merging?

@jbolor21 jbolor21 merged commit 32e3e17 into Azure:main Jun 27, 2024
4 of 5 checks passed
@jbolor21 jbolor21 deleted the users/bjagdagdorj/scorerErrorHandle branch June 27, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz left review comments

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbolor21 @romanlutz @rlundeen2